Skip to content

Commit c8d2aeb

Browse files
authored
Merge pull request #624 from 417-72KI/review-before-submmitted
Fix: `GitHub.Review.submittedAt` may be `nil`
2 parents b22f43c + 3261c11 commit c8d2aeb

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,11 @@
1313

1414
## Master
1515

16+
- Fix: `GitHub.Review.submittedAt` may be `nil` [@417-72KI][] - [#624](https://github.com/danger/swift/pull/624)
1617
- Drain stdout while shell commands are running to prevent execution from locking up if there's too much output [@jflan-dd][] - [#614](https://github.com/danger/swift/pull/614)
1718

1819
## 3.20.0
20+
1921
- Remove deprecated `lint` function with `lintAllFiles` flag [@417-72KI][] - [#622](https://github.com/danger/swift/pull/622)
2022
- Updated Swift 6 build process: Danger files moved to .build/debug/Modules, and SwiftFormat module map conflict resolved by adjusting the Swift import search path. [@abhi-m-simformsolutons][] -[#626](https://github.com/danger/swift/pull/626)
2123

Sources/Danger/GitHubDSL.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,8 @@ public extension GitHub {
323323
/// The state of the review (if a review was made).
324324
public let state: State?
325325

326-
/// The date when the review was submitted
327-
public let submittedAt: Date
326+
/// The date when the review was submitted (if a review was made).
327+
public let submittedAt: Date?
328328

329329
/// The user who has completed the review or has been requested to review.
330330
public let user: User

0 commit comments

Comments
 (0)