Skip to content

Commit f02749a

Browse files
authored
Merge pull request #537 from dahlborn/feature/Swift_5_7
2 parents 85cbade + 46a66fd commit f02749a

File tree

6 files changed

+17
-15
lines changed

6 files changed

+17
-15
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
- Add `reviewers` property for GitLab merge requests [@pouyayarandi][] - [#534](https://github.com/danger/swift/pull/534)
1717
- Update [SwiftLint][] used by [danger-swift-with-swiftlint][] from v0.46.1 to [v0.49.1](https://github.com/realm/SwiftLint/releases/tag/0.49.1). [@Kiran-B][] - [#538](https://github.com/danger/swift/pull/538)
18+
- Change `danger-swift edit` generated package to be compatible with swift 5.7 [@dahlborn][]
1819

1920
## 3.14.0
2021

@@ -533,4 +534,5 @@ This release also includes:
533534
[@pouyayarandi]: https://github.com/pouyayarandi
534535
[@Kiran-B]: https://github.com/Kiran-B
535536
[SwiftLint]: https://github.com/realm/SwiftLint
536-
[danger-swift-with-swiftlint]: https://github.com/orgs/danger/packages/container/package/danger-swift-with-swiftlint
537+
[danger-swift-with-swiftlint]: https://github.com/orgs/danger/packages/container/package/danger-swift-with-swiftlint
538+
[@dahlborn]: https://github.com/dahlborn

Sources/DangerDependenciesResolver/PackageGenerator.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ struct PackageGenerator {
3434
"let package = Package(\n" +
3535
" name: \"\(masterPackageName)\",\n" +
3636
(platform.isEmpty ? "" : " platforms: [\(platform)],\n") +
37-
" products: [.library(name: \"DangerDependencies\", " +
38-
"type: .dynamic, targets: [\"\(masterPackageName)\"])]," +
37+
" products: [.executable(name: \"DangerDependencies\", " +
38+
"targets: [\"\(masterPackageName)\"])]," +
3939
"\n" +
4040
" dependencies: [\n"
4141

@@ -48,7 +48,7 @@ struct PackageGenerator {
4848
}
4949

5050
description.append("\n ],\n")
51-
description.append(" targets: [.target(name: \"\(masterPackageName)\", dependencies: [")
51+
description.append(" targets: [.executableTarget(name: \"\(masterPackageName)\", dependencies: [")
5252

5353
if !packages.isEmpty {
5454
description.append("\"")
@@ -72,7 +72,7 @@ struct PackageGenerator {
7272

7373
func makePackageDescriptionHeader(forSwiftToolsVersion toolsVersion: Version) -> String {
7474
let swiftVersion = "\(toolsVersion.major).\(toolsVersion.minor)"
75-
let generationVersion = 2
75+
let generationVersion = 3
7676

7777
return "// swift-tools-version:\(swiftVersion)\n" +
7878
"// danger-dependency-generator-version:\(generationVersion)"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
// swift-tools-version:4.2
2-
// danger-dependency-generator-version:2
2+
// danger-dependency-generator-version:3
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
// swift-tools-version:5.0
2-
// danger-dependency-generator-version:2
2+
// danger-dependency-generator-version:3
33

44
import PackageDescription
55

66
let package = Package(
77
name: "PACKAGES",
88
platforms: [.macOS(.v12)],
9-
products: [.library(name: "DangerDependencies", type: .dynamic, targets: ["PACKAGES"])],
9+
products: [.executable(name: "DangerDependencies", targets: ["PACKAGES"])],
1010
dependencies: [
1111
.package(url: "https://github.com/danger/dependency1", from: "1.0.0"),
1212
.package(url: "https://github.com/danger/dependency2", from: "2.0.0"),
1313
.package(url: "https://github.com/danger/dependency3", from: "3.0.0")
1414
],
15-
targets: [.target(name: "PACKAGES", dependencies: ["Dependency1", "Dependency2", "Dependency3"])],
15+
targets: [.executableTarget(name: "PACKAGES", dependencies: ["Dependency1", "Dependency2", "Dependency3"])],
1616
swiftLanguageVersions: [.version("5")]
1717
)
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
// swift-tools-version:5.2
2-
// danger-dependency-generator-version:2
2+
// danger-dependency-generator-version:3
33

44
import PackageDescription
55

66
let package = Package(
77
name: "PACKAGES",
88
platforms: [.macOS(.v12)],
9-
products: [.library(name: "DangerDependencies", type: .dynamic, targets: ["PACKAGES"])],
9+
products: [.executable(name: "DangerDependencies", targets: ["PACKAGES"])],
1010
dependencies: [
1111
.package(name: "Dependency1", url: "https://github.com/danger/dependency1", from: "1.0.0"),
1212
.package(name: "Dependency2", url: "https://github.com/danger/dependency2", from: "2.0.0"),
1313
.package(name: "Dependency3", url: "https://github.com/danger/dependency3", from: "3.0.0")
1414
],
15-
targets: [.target(name: "PACKAGES", dependencies: ["Dependency1", "Dependency2", "Dependency3"])],
15+
targets: [.executableTarget(name: "PACKAGES", dependencies: ["Dependency1", "Dependency2", "Dependency3"])],
1616
swiftLanguageVersions: [.version("5")]
1717
)
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
// swift-tools-version:5.0
2-
// danger-dependency-generator-version:2
2+
// danger-dependency-generator-version:3
33

44
import PackageDescription
55

66
let package = Package(
77
name: "PACKAGES",
88
platforms: [.macOS(.v12)],
9-
products: [.library(name: "DangerDependencies", type: .dynamic, targets: ["PACKAGES"])],
9+
products: [.executable(name: "DangerDependencies", targets: ["PACKAGES"])],
1010
dependencies: [
1111

1212
],
13-
targets: [.target(name: "PACKAGES", dependencies: [])],
13+
targets: [.executableTarget(name: "PACKAGES", dependencies: [])],
1414
swiftLanguageVersions: [.version("5")]
1515
)

0 commit comments

Comments
 (0)