Skip to content

Commit 47b5d3b

Browse files
author
Daniel Duong
committed
fix(automl/create, autorag/create): validation errors for display_name
1 parent 85221ca commit 47b5d3b

2 files changed

Lines changed: 33 additions & 5 deletions

File tree

packages/automl/frontend/src/app/components/create/AutomlCreate.tsx

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
import { FormGroup, TextArea, TextInput } from '@patternfly/react-core';
1+
import {
2+
FormGroup,
3+
FormHelperText,
4+
HelperText,
5+
HelperTextItem,
6+
TextArea,
7+
TextInput,
8+
} from '@patternfly/react-core';
29
import React from 'react';
310
import { Controller, useFormContext } from 'react-hook-form';
411
import { ConfigureSchema } from '~/app/schemas/configure.schema';
@@ -11,9 +18,16 @@ function AutomlCreate(): React.JSX.Element {
1118
<Controller
1219
control={form.control}
1320
name="display_name"
14-
render={({ field }) => (
21+
render={({ field, fieldState }) => (
1522
<FormGroup fieldId={field.name} label="Name" isRequired>
1623
<TextInput {...field} id={field.name} type="text" isRequired />
24+
{fieldState.error && (
25+
<FormHelperText>
26+
<HelperText>
27+
<HelperTextItem variant="error">{fieldState.error.message}</HelperTextItem>
28+
</HelperText>
29+
</FormHelperText>
30+
)}
1731
</FormGroup>
1832
)}
1933
/>

packages/autorag/frontend/src/app/components/create/AutoragCreate.tsx

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,16 @@
1-
import { FormGroup, TextArea, TextInput } from '@patternfly/react-core';
1+
import {
2+
FormGroup,
3+
FormHelperText,
4+
HelperText,
5+
HelperTextItem,
6+
TextArea,
7+
TextInput,
8+
} from '@patternfly/react-core';
29
import React, { useEffect } from 'react';
310
import { Controller, useFormContext } from 'react-hook-form';
411
import { useParams } from 'react-router';
5-
import { ConfigureSchema } from '~/app/schemas/configure.schema';
612
import SecretSelector, { SecretSelection } from '~/app/components/common/SecretSelector';
13+
import { ConfigureSchema } from '~/app/schemas/configure.schema';
714

815
function AutoragCreate(): React.JSX.Element {
916
const { namespace } = useParams();
@@ -28,9 +35,16 @@ function AutoragCreate(): React.JSX.Element {
2835
<Controller
2936
control={form.control}
3037
name="display_name"
31-
render={({ field }) => (
38+
render={({ field, fieldState }) => (
3239
<FormGroup fieldId={field.name} label="Name" isRequired>
3340
<TextInput {...field} id={field.name} type="text" isRequired />
41+
{fieldState.error && (
42+
<FormHelperText>
43+
<HelperText>
44+
<HelperTextItem variant="error">{fieldState.error.message}</HelperTextItem>
45+
</HelperText>
46+
</FormHelperText>
47+
)}
3448
</FormGroup>
3549
)}
3650
/>

0 commit comments

Comments
 (0)