fix(cypress): extend sidebar poll timeout past defaultCommandTimeout (opendatahub-io#7410)

Author: ikeola13

packages/cypress/cypress/utils/oc_commands/genAi.ts

@@ -81,26 +81,31 @@ const waitForGenAiStudioFeatureFlag = (): Cypress.Chainable<Cypress.Exec> => {
   });
 };
 
-/**
- * Check if the Gen AI Studio section exists in the sidebar.
- *
- * @returns A Cypress chainable resolving to true if the section exists, false otherwise.
- */
 /**
  * Retry-aware check for an element inside the sidebar.
  * See `findNavItemInSidebar` in mlflow.ts for rationale.
+ *
+ * After `dashboard-page-main` appears, extension nav items can render asynchronously.
+ * Poll the live `#page-sidebar` DOM (not only the initial command subject) until the
+ * selector matches or the settle window elapses.
+ *
+ * The inner poll can run up to `NAV_ITEM_SETTLE_MS`; `.then()` must use a longer timeout
+ * than `defaultCommandTimeout` (10s) or Cypress aborts while the Promise is still pending.
  */
 const SIDEBAR_SETTLE_TIMEOUT = 30000;
 const NAV_ITEM_SETTLE_MS = 15000;
 const NAV_ITEM_POLL_MS = 500;
+const NAV_ITEM_FIND_TIMEOUT_MS = NAV_ITEM_SETTLE_MS + 5000;
 
 const findInSidebar = (selector: string): Cypress.Chainable<boolean> =>
   appChrome.findSideBar().then(
-    ($sidebar) =>
+    { timeout: NAV_ITEM_FIND_TIMEOUT_MS },
+    () =>
       new Cypress.Promise<boolean>((resolve) => {
         const deadline = Date.now() + NAV_ITEM_SETTLE_MS;
         const poll = () => {
-          if ($sidebar.find(selector).length > 0) {
+          const $sidebar = Cypress.$('#page-sidebar');
+          if ($sidebar.length > 0 && $sidebar.find(selector).length > 0) {
             resolve(true);
           } else if (Date.now() >= deadline) {
             resolve(false);

packages/cypress/cypress/utils/oc_commands/mlflow.ts

@@ -237,19 +237,25 @@ const logSidebarDiagnostics = (): void => {
  * yet contain extension items. A one-shot jQuery `.find()` during that gap
  * always misses the item, making the outer reload loop retry needlessly.
  *
- * This helper polls the live jQuery element for up to `NAV_ITEM_SETTLE_MS`
+ * This helper polls the live `#page-sidebar` DOM for up to `NAV_ITEM_SETTLE_MS`
  * so that a single page load is enough once the extensions are ready.
+ *
+ * `.then()` must allow longer than `defaultCommandTimeout` (10s) while the inner
+ * `Cypress.Promise` polls for up to `NAV_ITEM_SETTLE_MS` (15s).
  */
 const NAV_ITEM_SETTLE_MS = 15000;
 const NAV_ITEM_POLL_MS = 500;
+const NAV_ITEM_FIND_TIMEOUT_MS = NAV_ITEM_SETTLE_MS + 5000;
 
-const findNavItemInSidebar = ($sidebar: JQuery, navLabel: string): Cypress.Chainable<boolean> =>
+const findNavItemInSidebar = (navLabel: string): Cypress.Chainable<boolean> =>
   cy.wrap(null, { log: false }).then(
+    { timeout: NAV_ITEM_FIND_TIMEOUT_MS },
     () =>
       new Cypress.Promise<boolean>((resolve) => {
         const deadline = Date.now() + NAV_ITEM_SETTLE_MS;
         const poll = () => {
-          if ($sidebar.find(`a:contains("${navLabel}")`).length > 0) {
+          const $sidebar = Cypress.$('#page-sidebar');
+          if ($sidebar.length > 0 && $sidebar.find(`a:contains("${navLabel}")`).length > 0) {
             resolve(true);
           } else if (Date.now() >= deadline) {
             resolve(false);
@@ -278,7 +284,7 @@ const waitForNavItemInSidebar = (navLabel: string): Cypress.Chainable<boolean> =
 
     return appChrome
       .findSideBar()
-      .then(($sidebar) => findNavItemInSidebar($sidebar, navLabel))
+      .then(() => findNavItemInSidebar(navLabel))
       .then((found) => {
         const elapsedTime = ((Date.now() - startTime) / 1000).toFixed(1);