fix(autorag/create): address coderabbit

Author: Daniel Duong

packages/autorag/bff/internal/api/middleware.go

@@ -50,14 +50,24 @@ func isValidDNS1123Label(label string) bool {
 
 // getSecretDataCaseInsensitive performs a case-insensitive lookup in secret data.
 // Returns the value and true if found, empty string and false if not found.
-func getSecretDataCaseInsensitive(data map[string][]byte, key string) (string, bool) {
-	lowerKey := strings.ToLower(key)
+func getSecretDataCaseInsensitive(data map[string][]byte, key string) (string, bool, error) {
+	// Prefer exact key when present.
+	if v, ok := data[key]; ok {
+		return string(v), true, nil
+	}
+
+	var matched string
+	found := false
 	for k, v := range data {
-		if strings.ToLower(k) == lowerKey {
-			return string(v), true
+		if strings.EqualFold(k, key) {
+			if found {
+				return "", false, fmt.Errorf("ambiguous secret data: multiple keys match %q case-insensitively", key)
+			}
+			matched = string(v)
+			found = true
 		}
 	}
-	return "", false
+	return matched, found, nil
 }
 
 // isValidDNS1123Subdomain validates a string against DNS-1123 subdomain rules
@@ -372,8 +382,16 @@ func (app *App) AttachLlamaStackClientFromSecret(next func(http.ResponseWriter,
 			}
 
 			// Extract LlamaStack credentials from secret data using case-insensitive key lookups.
-			baseURL, foundBaseURL := getSecretDataCaseInsensitive(foundSecret.Data, "llama_stack_client_base_url")
-			apiKey, foundAPIKey := getSecretDataCaseInsensitive(foundSecret.Data, "llama_stack_client_api_key")
+			baseURL, foundBaseURL, err := getSecretDataCaseInsensitive(foundSecret.Data, "llama_stack_client_base_url")
+			if err != nil {
+				app.badRequestResponse(w, r, fmt.Errorf("invalid secret %q: %w", secretName, err))
+				return
+			}
+			apiKey, foundAPIKey, err := getSecretDataCaseInsensitive(foundSecret.Data, "llama_stack_client_api_key")
+			if err != nil {
+				app.badRequestResponse(w, r, fmt.Errorf("invalid secret %q: %w", secretName, err))
+				return
+			}
 
 			if !foundBaseURL || baseURL == "" {
 				app.badRequestResponse(w, r, fmt.Errorf("secret %q is missing or has empty value for required key: llama_stack_client_base_url", secretName))

packages/autorag/frontend/src/app/components/configure/AutoragExperimentSettings.tsx

@@ -169,7 +169,7 @@ const AutoragExperimentSettings: React.FC<AutoragExperimentSettingsProps> = ({
       <ModalFooter>
         <Button
           variant="primary"
-          onClick={() => onClose()}
+          onClick={onClose}
           isDisabled={!isDirty || hasFieldErrors}
           data-testid="experiment-settings-save"
         >

packages/autorag/frontend/src/app/hooks/mutations.ts

@@ -1,6 +1,6 @@
 import { useMutation, UseMutationResult } from '@tanstack/react-query';
 import { handleRestFailures, isModArchResponse, restCREATE } from 'mod-arch-core';
-import z from 'zod';
+import * as z from 'zod';
 import type { PipelineRun } from '~/app/types';
 import { BFF_API_VERSION, URL_PREFIX } from '~/app/utilities/const';
 

packages/autorag/frontend/src/app/hooks/queries.ts

@@ -1,4 +1,5 @@
 import { useQuery, UseQueryResult } from '@tanstack/react-query';
+import * as z from 'zod';
 import { getLlamaStackModels } from '~/app/api/k8s';
 import { LlamaStackModelsResponse, LlamaStackModelType } from '~/app/types';
 
@@ -9,7 +10,29 @@ export function useLlamaStackModelsQuery(
 ): UseQueryResult<LlamaStackModelsResponse, Error> {
   return useQuery({
     queryKey: ['models', namespace, secretName, modelType],
-    queryFn: () => getLlamaStackModels('')(namespace, secretName)({}),
+    enabled: !!namespace && !!secretName,
+    queryFn: async () => {
+      try {
+        const response = await getLlamaStackModels('')(namespace, secretName)({});
+        z.object({
+          models: z.array(
+            z.object({
+              id: z.string(),
+              type: z.union([z.literal('llm'), z.literal('embedding')]),
+              provider: z.string(),
+              // eslint-disable-next-line camelcase
+              resource_path: z.string(),
+            }),
+          ),
+        }).parse(response);
+        return response;
+      } catch (error) {
+        if (error instanceof z.ZodError) {
+          throw new Error('Invalid llama stack models response');
+        }
+        throw error;
+      }
+    },
     select: modelType
       ? (data) => ({ models: data.models.filter((m) => m.type === modelType) })
       : undefined,