Skip to content

Commit fd6f52a

Browse files
author
Daniel Duong
committed
fix: remove duplicate flags
1 parent a2fd0ed commit fd6f52a

7 files changed

Lines changed: 9 additions & 21 deletions

File tree

backend/src/types.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,12 @@ export type DashboardConfig = K8sResourceCommon & {
5151
disableFeatureStore: boolean;
5252
trainingJobs: boolean;
5353
genAiStudio: boolean;
54-
autoRag: boolean;
54+
autorag: boolean;
5555
modelAsService: boolean;
5656
mlflow: boolean;
5757
disableLLMd: boolean;
5858
projectRBAC: boolean;
5959
maasApiKeys: boolean;
60-
autorag: boolean;
6160
};
6261
// Intentionally disjointed from the CRD, we should move away from this code-wise now; CRD later
6362
// groupsConfig?: {

backend/src/utils/constants.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export const blankDashboardCR: DashboardConfig = {
8181
disableAdminConnectionTypes: false,
8282
disableFeatureStore: false,
8383
genAiStudio: false,
84-
autoRag: false,
84+
autorag: false,
8585
modelAsService: false,
8686
maasApiKeys: false,
8787
disableFineTuning: true,
@@ -91,7 +91,6 @@ export const blankDashboardCR: DashboardConfig = {
9191
trainingJobs: true,
9292
disableLLMd: false,
9393
projectRBAC: true,
94-
autorag: false,
9594
},
9695
notebookController: {
9796
enabled: true,

frontend/src/__mocks__/mockDashboardConfig.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export type MockDashboardConfigType = {
4040
disableKueue?: boolean;
4141
disableFeatureStore?: boolean;
4242
genAiStudio?: boolean;
43-
autoRag?: boolean;
43+
autorag?: boolean;
4444
modelAsService?: boolean;
4545
maasApiKeys?: boolean;
4646
trainingJobs?: boolean;
@@ -50,7 +50,6 @@ export type MockDashboardConfigType = {
5050
mlflow?: boolean;
5151
projectRBAC?: boolean;
5252
disableLLMd?: boolean;
53-
autorag?: boolean;
5453
};
5554

5655
export const mockDashboardConfig = ({
@@ -63,7 +62,7 @@ export const mockDashboardConfig = ({
6362
disableBYONImageStream = false,
6463
disableISVBadges = false,
6564
genAiStudio = false,
66-
autoRag = false,
65+
autorag = false,
6766
modelAsService = true,
6867
maasApiKeys = false,
6968
disableAppLauncher = false,
@@ -94,7 +93,6 @@ export const mockDashboardConfig = ({
9493
trainingJobs = true,
9594
observabilityDashboard = false,
9695
disableLLMd = false,
97-
autorag = false,
9896
hardwareProfileOrder = ['test-hardware-profile'],
9997
modelServerSizes = [
10098
{
@@ -240,7 +238,7 @@ export const mockDashboardConfig = ({
240238
disablePerformanceMetrics,
241239
disableKServe,
242240
genAiStudio,
243-
autoRag,
241+
autorag,
244242
modelAsService,
245243
maasApiKeys,
246244
disableKServeAuth,
@@ -261,7 +259,6 @@ export const mockDashboardConfig = ({
261259
trainingJobs,
262260
observabilityDashboard,
263261
disableLLMd,
264-
autorag,
265262
},
266263
notebookController: {
267264
enabled: !disableNotebookController,

frontend/src/concepts/areas/const.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,12 @@ import { SupportedArea, SupportedAreasState, DataScienceStackComponent } from '.
44
export const techPreviewFlags = {
55
disableModelRegistry: true,
66
genAiStudio: false,
7-
autoRag: false,
7+
autorag: false,
88
modelAsService: false,
99
maasApiKeys: false,
1010
mlflow: false,
1111
projectRBAC: true,
1212
observabilityDashboard: false,
13-
autorag: false,
1413
} satisfies Partial<DashboardCommonConfig>;
1514

1615
export const devTemporaryFeatureFlags = {

frontend/src/k8sTypes.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1301,14 +1301,13 @@ export type DashboardCommonConfig = {
13011301
trainingJobs: boolean;
13021302
disableFeatureStore?: boolean;
13031303
genAiStudio?: boolean;
1304-
autoRag?: boolean;
1304+
autorag?: boolean;
13051305
modelAsService?: boolean;
13061306
maasApiKeys?: boolean;
13071307
mlflow?: boolean;
13081308
projectRBAC?: boolean;
13091309
observabilityDashboard?: boolean;
13101310
disableLLMd?: boolean;
1311-
autorag?: boolean;
13121311
};
13131312

13141313
// [1] Intentionally disjointed fields from the CRD in this type definition

manifests/common/crd/odhdashboardconfigs.opendatahub.io.crd.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ spec:
105105
type: boolean
106106
genAiStudio:
107107
type: boolean
108+
autorag:
109+
type: boolean
108110
modelAsService:
109111
type: boolean
110112
mlflow:
@@ -117,8 +119,6 @@ spec:
117119
type: boolean
118120
disableLLMd:
119121
type: boolean
120-
autorag:
121-
type: boolean
122122
x-kubernetes-validations:
123123
- rule: '!has(self.disableAcceleratorProfiles) || self.disableAcceleratorProfiles == oldSelf.disableAcceleratorProfiles'
124124
message: 'DEPRECATED: spec.dashboardConfig.disableAcceleratorProfiles must be removed or left unchanged.'

packages/autorag/OWNERS

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)