fix: resolve PWA static file serving and button visibility issues#7
Merged
Conversation
Frontend changes: - Update PWA button to show on production HTTPS domains - Add timeout fallback for production domains when beforeinstallprompt doesn't fire - Add modern mobile-web-app-capable meta tag (fixes deprecation warning) - Improve console logging for debugging PWA conditions Backend changes: - Add proper static file serving for PWA files (favicon.svg, manifest.json, og-image.svg) - Add NoRoute handler to serve static files from dist directory - Ensure all PWA assets are accessible at production URLs This fixes the 404 errors for PWA files and makes the install button appear on production domains like babelbridge.world
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (21.42%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 57.08% 56.57% -0.52%
==========================================
Files 24 24
Lines 1948 1971 +23
Branches 105 108 +3
==========================================
+ Hits 1112 1115 +3
- Misses 808 826 +18
- Partials 28 30 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend changes: