fix clippy lints

Author: daniel5151

.cargo/config.toml

@@ -5,6 +5,7 @@ rustflags = [
     "-Drust_2018_idioms",
 
     "-Wmissing_docs",
+    "-Wunexpected_cfgs",
     "-Wunsafe_op_in_unsafe_fn",
 
     "-Wclippy::dbg_macro",
@@ -20,7 +21,6 @@ rustflags = [
     "-Wclippy::macro_use_imports",
     "-Wclippy::map_flatten",
     "-Wclippy::match_on_vec_items",
-    "-Wclippy::mismatched_target_os",
     "-Wclippy::needless_borrow",
     "-Wclippy::needless_continue",
     "-Wclippy::option_option",
@@ -31,7 +31,7 @@ rustflags = [
     "-Wclippy::verbose_file_reads",
 #   "-Wclippy::unused_self", # might be interesting to explore this...
 
-    # deny exlicit panic paths
+    # deny explicit panic paths
     "-Wclippy::panic",
     "-Wclippy::todo",
     "-Wclippy::unimplemented",

examples/armv4t/mem_sniffer.rs

@@ -66,7 +66,7 @@ macro_rules! impl_memsniff_w {
     };
 }
 
-impl<'a, M: Memory, F: FnMut(Access)> Memory for MemSniffer<'a, M, F> {
+impl<M: Memory, F: FnMut(Access)> Memory for MemSniffer<'_, M, F> {
     impl_memsniff_r!(r8, u8);
     impl_memsniff_r!(r16, u16);
     impl_memsniff_r!(r32, u32);

examples/armv4t_multicore/mem_sniffer.rs

@@ -68,7 +68,7 @@ macro_rules! impl_memsniff_w {
     };
 }
 
-impl<'a, M: Memory, F: FnMut(Access)> Memory for MemSniffer<'a, M, F> {
+impl<M: Memory, F: FnMut(Access)> Memory for MemSniffer<'_, M, F> {
     impl_memsniff_r!(r8, u8);
     impl_memsniff_r!(r16, u16);
     impl_memsniff_r!(r32, u32);

src/protocol/commands/_qXfer_auxv_read.rs

@@ -7,7 +7,7 @@ pub type qXferAuxvRead<'a> = QXferReadBase<'a, AuxvAnnex>;
 #[derive(Debug)]
 pub struct AuxvAnnex;
 
-impl<'a> ParseAnnex<'a> for AuxvAnnex {
+impl ParseAnnex<'_> for AuxvAnnex {
     #[inline(always)]
     fn from_buf(buf: &[u8]) -> Option<Self> {
         if buf != b"" {

src/protocol/commands/_qXfer_exec_file.rs

@@ -10,7 +10,7 @@ pub struct ExecFileAnnex {
     pub pid: Option<Pid>,
 }
 
-impl<'a> ParseAnnex<'a> for ExecFileAnnex {
+impl ParseAnnex<'_> for ExecFileAnnex {
     #[inline(always)]
     fn from_buf(buf: &[u8]) -> Option<Self> {
         let pid = match buf {

src/protocol/commands/_qXfer_libraries_svr4_read.rs

@@ -6,7 +6,7 @@ pub type qXferLibrariesSvr4Read<'a> = QXferReadBase<'a, LibrariesSvr4Annex>;
 #[derive(Debug)]
 pub struct LibrariesSvr4Annex;
 
-impl<'a> ParseAnnex<'a> for LibrariesSvr4Annex {
+impl ParseAnnex<'_> for LibrariesSvr4Annex {
     #[inline(always)]
     fn from_buf(buf: &[u8]) -> Option<Self> {
         if buf != b"" {

src/protocol/commands/_qXfer_memory_map.rs

@@ -7,7 +7,7 @@ pub type qXferMemoryMapRead<'a> = QXferReadBase<'a, MemoryMapAnnex>;
 #[derive(Debug)]
 pub struct MemoryMapAnnex;
 
-impl<'a> ParseAnnex<'a> for MemoryMapAnnex {
+impl ParseAnnex<'_> for MemoryMapAnnex {
     #[inline(always)]
     fn from_buf(buf: &[u8]) -> Option<Self> {
         if buf != b"" {

src/protocol/commands/_vCont.rs

@@ -150,7 +150,7 @@ pub enum VContKind<'a> {
     Stop,
 }
 
-impl<'a> VContKind<'a> {
+impl VContKind<'_> {
     #[inline(always)]
     fn from_bytes(s: &[u8]) -> Option<VContKind<'_>> {
         use self::VContKind::*;

src/protocol/console_output.rs

@@ -24,7 +24,7 @@ pub struct ConsoleOutput<'a> {
     callback: &'a mut dyn FnMut(&[u8]),
 }
 
-impl<'a> fmt::Write for ConsoleOutput<'a> {
+impl fmt::Write for ConsoleOutput<'_> {
     fn write_str(&mut self, s: &str) -> fmt::Result {
         self.write_raw(s.as_bytes());
         Ok(())

src/stub/state_machine.rs

@@ -180,7 +180,7 @@ pub struct GdbStubStateMachineInner<'a, S, T: Target, C: Connection> {
 }
 
 /// Methods which can be called regardless of the current state.
-impl<'a, S, T: Target, C: Connection> GdbStubStateMachineInner<'a, S, T, C> {
+impl<S, T: Target, C: Connection> GdbStubStateMachineInner<'_, S, T, C> {
     /// Return a mutable reference to the underlying connection.
     pub fn borrow_conn(&mut self) -> &mut C {
         &mut self.i.conn