Skip to content

Commit 844d9e1

Browse files
authored
Improve KubeRayCluster cleanup (#149)
Ensure that KubeRayCluster resources properly delete running ray clusters in case a dagster job fails with a `BaseException` type.
1 parent 4132c24 commit 844d9e1

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

dagster_ray/kuberay/resources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def yield_for_execution(self, context: InitResourceContext) -> Generator[Self, N
170170
self._context = None
171171

172172
yield self
173-
except Exception as e:
173+
except BaseException as e:
174174
context.log.critical(f"Couldn't create or connect to RayCluster {self.namespace}/{self.cluster_name}!")
175175
self._maybe_cleanup_raycluster(context)
176176
raise e

0 commit comments

Comments
 (0)