🐛 trim k8s labels to 63 characters (#97)

Author: danielgafni

dagster_ray/kuberay/utils.py

@@ -4,11 +4,12 @@
 def normalize_k8s_label_values(labels: dict[str, str]) -> dict[str, str]:
     # prevent errors like:
     # Invalid value: \"daniel@anam.ai\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')
+    # and comply with the 63 character limit
 
     cleanup_regex = re.compile(r"[^a-zA-Z0-9-_.]+")
 
     for key, value in labels.items():
         # daniel~!@my.domain -> daniel-my-domain
-        labels[key] = cleanup_regex.sub("", value.replace("@", "-").replace(".", "-"))
+        labels[key] = cleanup_regex.sub("", value.replace("@", "-").replace(".", "-"))[:63]
 
     return labels

tests/kuberay/test_utils.py

@@ -9,11 +9,13 @@ def test_normalize_k8s_label_values():
             "user": "daniel@my.org",
             "user-dirty": "daniel!`~@my.org",
             "alphanumeric": "abc123",
+            "long": 64 * "a",
         }
     ) == {
         "foo": "bar",
         "my/label": "myvalue",
         "user": "daniel-my-org",
         "user-dirty": "daniel-my-org",
         "alphanumeric": "abc123",
+        "long": 63 * "a",
     }