Skip to content

Commit ecef3ac

Browse files
fix: force quoting when dumping runtimeEnvYAML (#297)
1 parent ee19c66 commit ecef3ac

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

src/dagster_ray/kuberay/pipes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def _enrich_ray_job(
180180
runtime_env["env_vars"] = runtime_env.get("env_vars", {})
181181
runtime_env["env_vars"].update(env_vars)
182182

183-
ray_job["spec"]["runtimeEnvYAML"] = yaml.safe_dump(runtime_env)
183+
ray_job["spec"]["runtimeEnvYAML"] = yaml.safe_dump(runtime_env, default_style='"')
184184

185185
image_from_run_tag = context.run.tags.get("dagster/image")
186186

tests/kuberay/test_pipes.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import dagster as dg
44
import pytest
55
import ray # noqa: TID253
6+
import yaml
67
from dagster._core.definitions.data_version import (
78
DATA_VERSION_IS_USER_PROVIDED_TAG,
89
DATA_VERSION_TAG,
@@ -26,6 +27,7 @@
2627
"spec": {
2728
"activeDeadlineSeconds": 10800,
2829
"entrypoint": ENTRYPOINT,
30+
"runtimeEnvYAML": yaml.dump({"env_vars": {"FOO": "1E-5"}}, default_style='"'),
2931
"entrypointNumCpus": 0.1,
3032
"rayClusterSpec": {
3133
"autoscalerOptions": {

0 commit comments

Comments
 (0)