unnecessary changes were undone

Author: kfrajtak

src/WorkflowCore.Testing/WorkflowCore.Testing.csproj

@@ -12,7 +12,6 @@
     <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="3.1.0" />
     <PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.0" />
-    <PackageReference Include="xunit.abstractions" Version="2.0.3" />
   </ItemGroup>
 
   <ItemGroup>

src/WorkflowCore/Models/ExecutionPointer.cs

@@ -51,10 +51,6 @@ public IReadOnlyCollection<string> Scope
             get => _scope;
             set => _scope = new List<string>(value);
         }
-
-        public bool IsComplete => Status == PointerStatus.Complete;
-        
-        public bool HasChildren => Children?.Count > 0;
     }
 
     public enum PointerStatus

src/WorkflowCore/Services/ExecutionResultProcessor.cs

@@ -29,16 +29,12 @@ public ExecutionResultProcessor(IExecutionPointerFactory pointerFactory, IDateTi
 
         public void ProcessExecutionResult(WorkflowInstance workflow, WorkflowDefinition def, ExecutionPointer pointer, WorkflowStep step, ExecutionResult result, WorkflowExecutorResult workflowResult)
         {
-            var stepInfo = $"{step.Name ?? step.BodyType.Name} ({step.Id})";
-
             pointer.PersistenceData = result.PersistenceData;
             pointer.Outcome = result.OutcomeValue;
             if (result.SleepFor.HasValue)
             {
                 pointer.SleepUntil = _datetimeProvider.UtcNow.Add(result.SleepFor.Value);
                 pointer.Status = PointerStatus.Sleeping;
-                _logger.LogDebug("Step {StepName} on workflow {WorkflowDefinitionId} ({WorkflowId}) will sleep for {SleepUntil}",
-                    stepInfo, workflow.WorkflowDefinitionId, workflow.Id, result.SleepFor.Value);
             }
 
             if (!string.IsNullOrEmpty(result.EventName))
@@ -58,9 +54,6 @@ public void ProcessExecutionResult(WorkflowInstance workflow, WorkflowDefinition
                     SubscribeAsOf = result.EventAsOf,
                     SubscriptionData = result.SubscriptionData
                 });
-
-                _logger.LogDebug("Step {StepName} on workflow {WorkflowDefinitionId} ({WorkflowId}) waiting for event {EventName}",
-                    stepInfo, workflow.WorkflowDefinitionId, workflow.Id, pointer.EventName);
             }
 
             if (result.Proceed)
@@ -94,9 +87,6 @@ public void ProcessExecutionResult(WorkflowInstance workflow, WorkflowDefinition
                     WorkflowDefinitionId = workflow.WorkflowDefinitionId,
                     Version = workflow.Version
                 });
-
-                _logger.LogDebug("Step {StepName} on workflow {WorkflowDefinitionId} ({WorkflowId}) completed",
-                    stepInfo, workflow.WorkflowDefinitionId, workflow.Id);
             }
             else
             {

src/WorkflowCore/Services/WorkflowExecutor.cs

@@ -245,7 +245,7 @@ private async Task DetermineNextExecutionTime(WorkflowInstance workflow, Workflo
                 workflow.NextExecution = Math.Min(pointerSleep, workflow.NextExecution ?? pointerSleep);
             }
 
-            foreach (var pointer in workflow.ExecutionPointers.Where(x => x.Active && x.HasChildren))
+            foreach (var pointer in workflow.ExecutionPointers.Where(x => x.Active && (x.Children ?? new List<string>()).Count > 0))
             {
                 if (!workflow.ExecutionPointers.FindByScope(pointer.Id).All(x => x.EndTime.HasValue))
                     continue;
@@ -279,8 +279,6 @@ private async Task OnComplete(WorkflowInstance workflow, WorkflowDefinition def)
                 await middlewareRunner.RunPostMiddleware(workflow, def);
             }
 
-            _logger.LogDebug("Workflow {WorkflowDefinitionId} ({Id}) completed", workflow.WorkflowDefinitionId, workflow.Id);
-
             _publisher.PublishNotification(new WorkflowCompleted
             {
                 EventTimeUtc = _datetimeProvider.UtcNow,

src/providers/WorkflowCore.Persistence.EntityFramework/Services/EntityFrameworkPersistenceProvider.cs

@@ -100,10 +100,6 @@ public async Task<WorkflowInstance> GetWorkflowInstance(string Id, CancellationT
         {
             using (var db = ConstructDbContext())
             {
-                if (!Guid.TryParse(Id, out _))
-                {
-                    
-                }
                 var uid = new Guid(Id);
                 var raw = await db.Set<PersistedWorkflow>()
                     .Include(wf => wf.ExecutionPointers)