Skip to content

Added create_coding_feature pattern #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

nysan
Copy link

@nysan nysan commented Feb 20, 2025

This describes a JSON based filesystem interface for the chosen AI model via the pattern, and explicitly asks for output in said format. Input (project code) is provided via a similiar JSON based interface.

This allows fabric to directly apply file changes in $PWD subdirectories, for later human review in said humans favourite SCM tool.

Workflow:
$ code.py . "Validate user input, assume all users are google project zero" |
fabric -p create_coding_feature
$ git diff
$ git add
$ git commit -s -m "Validate user input with extreme judgement"

What this Pull Request (PR) does

Please briefly describe what this PR does.

Related issues

Please reference any open issues this PR relates to in here.
If it closes an issue, type closes #[ISSUE_NUMBER].

Screenshots

Provide any screenshots you may find relevant to facilitate us understanding your PR.

This describes a JSON based filesystem interface for the chosen
AI model via the pattern, and explicitly asks for output in said format.
Input (project code) is provided via a similiar JSON based interface.

This allows fabric to directly apply file changes in $PWD subdirectories, for
later human review in said humans favourite SCM tool.

Workflow:
$ code.py . "Validate user input, assume all users are google project zero" |
  fabric -p create_coding_feature
$ git diff
$ git add <files>
$ git commit -s -m "Validate user input with extreme judgement"
<repeat>

Signed-off-by: David Nyström <[email protected]>
@nysan
Copy link
Author

nysan commented Feb 20, 2025

This mostly an RFC PR, since I'm a bit unsure you want to deal with this kind of behavior in fabric. Let me know if you find the approach interesting.

@eugeis
Copy link
Collaborator

eugeis commented Feb 24, 2025

Hi, thank you for your PR.

Would you try to implement the functionality of code.py in fabric as a tool, the tools package (see examples https://github.com/danielmiessler/fabric/tree/main/plugins/tools)

@ksylvan
Copy link
Collaborator

ksylvan commented Mar 10, 2025

This mostly an RFC PR, since I'm a bit unsure you want to deal with this kind of behavior in fabric. Let me know if you find the approach interesting.

This is a really cool idea.

@ksylvan
Copy link
Collaborator

ksylvan commented Mar 19, 2025

@nysan Can you implement the feature as a new integrated tool like @eugeis suggests above?

@nysan
Copy link
Author

nysan commented Mar 19, 2025

I started, but have not found time to do so. If someone want to continue, I could share what I have now.

@ksylvan
Copy link
Collaborator

ksylvan commented Mar 20, 2025

@nysan I can take a crack at it. I'll grab your branch locally and see what I can do.

@ksylvan ksylvan mentioned this pull request Mar 26, 2025
@ksylvan
Copy link
Collaborator

ksylvan commented Mar 26, 2025

@nysan @eugeis Look at #1389

This is a Go re-implementation of the idea in this PR. One fun bit: I was able to use it to debug and fix issues in the PR itself when it was in a mostly working state.

@nysan
Copy link
Author

nysan commented Mar 26, 2025

Nice !, I found the python prototype surprisingly helpful in minor to small tasks also. Especially in languages where I am a novice.

@eugeis
Copy link
Collaborator

eugeis commented Mar 26, 2025

@nysan , @ksylvan Thank you!
Then, I will close this one.

@eugeis eugeis closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants