Merge pull request #767 from aluedeke/fix/forward-connect-log-level

fix(forward): quiet per-connection logs and return the real connect error

Author: danielpaulus

ios/forward/forward.go

@@ -79,7 +79,7 @@ func connectionAccept(cl *ConnListener, deviceID int, phonePort uint16) {
 				golog.Error("error accepting new connection", "module", logModule, "deviceID", deviceID, "phonePort", phonePort, "error", err)
 				continue
 			}
-			golog.Info("new client connected", "module", logModule, "deviceID", deviceID, "phonePort", phonePort, "conn", fmt.Sprintf("%#v", cl))
+			golog.Debug("new client connected", "module", logModule, "deviceID", deviceID, "phonePort", phonePort, "conn", fmt.Sprintf("%#v", cl))
 			go StartNewProxyConnection(context.TODO(), clientConn, deviceID, phonePort)
 		}
 	}
@@ -94,11 +94,11 @@ func StartNewProxyConnection(ctx context.Context, clientConn io.ReadWriteCloser,
 	}
 	muxError := usbmuxConn.Connect(deviceID, phonePort)
 	if muxError != nil {
-		golog.Info("could not connect to phone", "module", logModule, "deviceID", deviceID, "conn", fmt.Sprintf("%#v", clientConn), "error", muxError, "phonePort", phonePort)
+		golog.Debug("could not connect to phone", "module", logModule, "deviceID", deviceID, "conn", fmt.Sprintf("%#v", clientConn), "error", muxError, "phonePort", phonePort)
 		clientConn.Close()
-		return fmt.Errorf("could not connect to port:%d on iOS: %v", phonePort, err)
+		return fmt.Errorf("could not connect to port:%d on iOS: %v", phonePort, muxError)
 	}
-	golog.Info("connected to port", "module", logModule, "deviceID", deviceID, "conn", fmt.Sprintf("%#v", clientConn), "phonePort", phonePort)
+	golog.Debug("connected to port", "module", logModule, "deviceID", deviceID, "conn", fmt.Sprintf("%#v", clientConn), "phonePort", phonePort)
 	deviceConn := usbmuxConn.ReleaseDeviceConnection()
 
 	proxyConns(ctx, clientConn, deviceConn, deviceID, phonePort)