Merge pull request #740 from danielpaulus/chore/bump-deprecated-gha-node20

danielpaulus · web-flow · commit d1160ef769e6 · 2026-06-04T10:08:43.000+02:00
chore(ci): refresh GitHub Actions + bump Go to 1.26
diff --git a/.githooks/pre-commit b/.githooks/pre-commit
@@ -1,19 +1,11 @@
 #!/bin/sh
 # Pre-commit hook for go-ios
-# Runs gofmt and golangci-lint before allowing commits
+# Runs gofmt and go vet before allowing commits
 
 set -e
 
 echo "Running pre-commit checks..."
 
-# Check if golangci-lint is installed
-if ! command -v golangci-lint &> /dev/null; then
-    echo "Error: golangci-lint is not installed."
-    echo "Install it with: brew install golangci-lint"
-    echo "Or see: https://golangci-lint.run/docs/welcome/install/"
-    exit 1
-fi
-
 # Check formatting
 echo "Checking code formatting..."
 UNFORMATTED=$(gofmt -l .)
@@ -25,11 +17,10 @@ if [ -n "$UNFORMATTED" ]; then
     exit 1
 fi
 
-# Run linter
-echo "Running golangci-lint..."
-golangci-lint run
-if [ $? -ne 0 ]; then
-    echo "Error: Linter found issues. Please fix them before committing."
+# Run go vet
+echo "Running go vet..."
+if ! go vet ./...; then
+    echo "Error: go vet found issues. Please fix them before committing."
     exit 1
 fi
 
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -8,7 +8,7 @@ jobs:
     runs-on: self-hosted
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Extract ngrok url
         run: |
@@ -25,7 +25,7 @@ jobs:
           environment: staging
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
diff --git a/.github/workflows/device-tests-comment.yml b/.github/workflows/device-tests-comment.yml
@@ -26,7 +26,7 @@ jobs:
       pull-requests: write
     steps:
       - name: Acknowledge the command
-        uses: actions/github-script@v7
+        uses: actions/github-script@v9
         with:
           script: |
             await github.rest.reactions.createForIssueComment({
@@ -59,7 +59,7 @@ jobs:
       issues: write
       pull-requests: write
     steps:
-      - uses: actions/github-script@v7
+      - uses: actions/github-script@v9
         with:
           script: |
             const ok = '${{ needs.real-device.result }}' === 'success';
diff --git a/.github/workflows/real-device.yml b/.github/workflows/real-device.yml
@@ -34,12 +34,12 @@ jobs:
             tunnel_devices: GO_IOS_E2E_LINUX_TUNNEL_DEVICES
     runs-on: [self-hosted, "${{ matrix.os }}"]
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           ref: ${{ inputs.ref }}
 
       - name: Install Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: false
diff --git a/.github/workflows/release-canary.yml b/.github/workflows/release-canary.yml
@@ -14,10 +14,10 @@ jobs:
   build_on_windows:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
@@ -30,7 +30,7 @@ jobs:
           Compress-Archive -Path .\bin\ios.exe -CompressionLevel Optimal -DestinationPath go-ios-windows.zip
 
       - name: upload the windows build
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: windows-build
           path: go-ios-windows.zip
@@ -41,10 +41,10 @@ jobs:
     runs-on: macos-latest
     needs: build_on_windows
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
@@ -60,7 +60,7 @@ jobs:
           zip -j go-ios-mac.zip bin/ios
 
       - name: upload the macos build
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: macos-build
           path: go-ios-mac.zip
@@ -75,16 +75,16 @@ jobs:
       # publishing. No contents: write here — canary does not cut a GitHub release.
       id-token: write
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
 
       - name: Download mac build from previous job
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: macos-build
           path: ./mac-bin
@@ -95,7 +95,7 @@ jobs:
           unzip go-ios-mac.zip
 
       - name: Download windows build from previous job
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: windows-build
           path: ./win-bin
@@ -114,7 +114,7 @@ jobs:
 
       # OIDC trusted publishing needs Node >= 22.14.0 and npm >= 11.5.1.
       - name: Set up Node
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: '22'
           registry-url: 'https://registry.npmjs.org'
@@ -156,7 +156,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Set up Node
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: '22'
           registry-url: 'https://registry.npmjs.org'
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -38,7 +38,7 @@ jobs:
     outputs:
       version: ${{ steps.compute.outputs.version }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
         with:
           ref: main
           fetch-depth: 0 # need all tags to find the latest
@@ -63,10 +63,10 @@ jobs:
     runs-on: windows-latest
     needs: prepare_version
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
@@ -79,7 +79,7 @@ jobs:
           Compress-Archive -Path .\bin\ios.exe -CompressionLevel Optimal -DestinationPath go-ios-windows.zip
 
       - name: upload the windows build
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: windows-build
           path: go-ios-windows.zip
@@ -90,10 +90,10 @@ jobs:
     runs-on: macos-latest
     needs: [prepare_version, build_on_windows]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
@@ -109,7 +109,7 @@ jobs:
           zip -j go-ios-mac.zip bin/ios
 
       - name: upload the macos build
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: macos-build
           path: go-ios-mac.zip
@@ -125,26 +125,26 @@ jobs:
     env:
       VERSION: ${{ needs.prepare_version.outputs.version }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
         with:
           ref: main
           fetch-depth: 0
           token: ${{ secrets.RELEASE_PAT }} # admin token, can push to protected main
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
 
       - name: Download mac build from previous job
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: macos-build
           path: ./mac-bin
 
       - name: Download windows build from previous job
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v8
         with:
           name: windows-build
           path: ./win-bin
@@ -203,7 +203,7 @@ jobs:
 
       # OIDC trusted publishing needs Node >= 22.14.0 and npm >= 11.5.1.
       - name: Set up Node
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: '22'
           registry-url: 'https://registry.npmjs.org'
@@ -242,7 +242,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - name: Set up Node
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: '22'
           registry-url: 'https://registry.npmjs.org'
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -6,28 +6,26 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
 
       - name: Install libusb
         run: sudo apt-get update && sudo apt-get install -y libusb-1.0-0-dev
 
-      - name: Run golangci-lint
-        uses: golangci/golangci-lint-action@v9
-        with:
-          version: v2.6
+      - name: Run go vet
+        run: go vet ./...
 
   test_on_windows:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
@@ -44,10 +42,10 @@ jobs:
   test_on_linux:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
 
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version-file: go.mod
           cache: true
diff --git a/.golangci.yml b/.golangci.yml
diff --git a/Makefile b/Makefile
@@ -32,7 +32,7 @@ up: build run
 
 # Run linter
 lint:
-	@golangci-lint run
+	@go vet ./...
 
 # Setup development environment (installs git hooks)
 setup:
diff --git a/go.mod b/go.mod
@@ -1,8 +1,8 @@
 module github.com/danielpaulus/go-ios
 
-go 1.24.0
+go 1.26.0
 
-toolchain go1.24.13
+toolchain go1.26.4
 
 require (
 	github.com/Masterminds/semver v1.5.0
diff --git a/go.work b/go.work
@@ -1,6 +1,6 @@
-go 1.24.0
+go 1.26.0
 
-toolchain go1.24.13
+toolchain go1.26.4
 
 use (
 	.
diff --git a/ios/debugproxy/debugproxy.go b/ios/debugproxy/debugproxy.go
@@ -185,7 +185,7 @@ func (d *DebugProxy) setupDirectory() {
 	os.MkdirAll(newpath, os.ModePerm)
 }
 
-func (d DebugProxy) addConnectionInfoToJsonFile(connInfo ConnectionInfo) {
+func (d *DebugProxy) addConnectionInfoToJsonFile(connInfo ConnectionInfo) {
 	file, err := os.OpenFile(filepath.Join(d.WorkingDir, connectionJSONFileName),
 		os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0o644)
 	if err != nil {
@@ -200,13 +200,13 @@ func (d DebugProxy) addConnectionInfoToJsonFile(connInfo ConnectionInfo) {
 	file.Close()
 }
 
-func (p ProxyConnection) logJSONMessageFromDevice(msg map[string]interface{}) {
+func (p *ProxyConnection) logJSONMessageFromDevice(msg map[string]interface{}) {
 	const outPath = "jsondump.json"
 	msg["direction"] = "device->host"
 	writeJSON(filepath.Join(p.info.ConnectionPath, outPath), msg)
 }
 
-func (p ProxyConnection) logJSONMessageToDevice(msg map[string]interface{}) {
+func (p *ProxyConnection) logJSONMessageToDevice(msg map[string]interface{}) {
 	const outPath = "jsondump.json"
 	msg["direction"] = "host->device"
 	writeJSON(filepath.Join(p.info.ConnectionPath, outPath), msg)
diff --git a/ncm/go.mod b/ncm/go.mod
diff --git a/restapi/go.mod b/restapi/go.mod
