code cleaning (fortran linter fortitude)

Author: danielpeter

src/auxiliaries/combine_vol_data_impl.f90

@@ -29,6 +29,8 @@ module combine_vtk_par
 
     use constants, only: CUSTOM_REAL
 
+    implicit none
+
     ! global point data
     real(kind=CUSTOM_REAL),dimension(:),allocatable :: total_dat
 

src/decompose_mesh/module_database.f90

@@ -31,6 +31,7 @@ module module_database
   use shared_parameters, only: NGNOD, NGNOD2D, LOCAL_PATH, MSL => MAX_STRING_LEN
   use fault_scotch
 
+  implicit none
   integer                                     :: nE_loc
   integer, dimension(:),  allocatable         :: loc2glob_elmnt
   integer, dimension(:),  allocatable         :: glob2loc_elmnt

src/decompose_mesh/module_mesh.f90

@@ -31,6 +31,8 @@ module module_mesh
   use shared_parameters, only: NGNOD,NGNOD2D,ATTENUATION,PML_CONDITIONS
   use fault_scotch
 
+  implicit none
+
   ! elements
   integer                                                    :: nspec, nspec_glob
   integer,               dimension(:,:),        allocatable  :: elmnts, elmnts_glob

src/decompose_mesh/module_partition.f90

@@ -31,6 +31,8 @@ module module_partition
   use shared_parameters, only: NGNOD
   use module_qsort
 
+  implicit none
+
   integer                                                  :: nE
   integer,             dimension(:),  allocatable          :: ipart
 

src/decompose_mesh/part_decompose_mesh_hdf5.F90

@@ -31,11 +31,13 @@ module part_decompose_mesh_hdf5
   use constants, only: MAX_STRING_LEN,NGNOD2D_FOUR_CORNERS,NGNOD_EIGHT_CORNERS
 
 #ifdef USE_HDF5
-
   use manager_hdf5
+#endif
 
   implicit none
 
+#ifdef USE_HDF5
+
 contains
   !--------------------------------------------------
   ! Write nodes (their coordinates) pertaining to iproc partition in the corresponding Database
@@ -135,11 +137,11 @@ subroutine write_material_props_database_h5(count_def_mat, &
   ! name for material data group
   character(len=14), parameter :: gname_material   = "material_props" ! Group name for material properties
   ! for attribute count_def_mat and count_undef_mat
-  character(len=13)              :: m_aname = "count_def_mat"
-  character(len=15)              :: u_aname = "count_undef_mat"
+  character(len=13), parameter :: m_aname = "count_def_mat"
+  character(len=15), parameter :: u_aname = "count_undef_mat"
   ! for dataset mat_prop, undef_mat_prop
-  character(len=40)              :: mdsetname = "mat_prop"
-  character(len=40)              :: udsetname = "undef_mat_prop"
+  character(len=40), parameter :: mdsetname = "mat_prop"
+  character(len=40), parameter :: udsetname = "undef_mat_prop"
 
   ! prepare groups in hdf5 file
   ! material data group
@@ -618,7 +620,10 @@ subroutine write_partition_database_h5(iproc, nspec, elmnts, &
   ! for ispec_local
   integer, dimension(:), allocatable :: ispec_local
 
-  integer :: o = 0
+  integer:: off
+
+  ! initializes
+  off = 0
 
   if (num_phase == 1) then
     ! counts number of spectral elements in this partition
@@ -640,7 +645,7 @@ subroutine write_partition_database_h5(iproc, nspec, elmnts, &
     allocate(ispec_local(offset_nelems(iproc)))
 
     ! node id offset
-    o = sum(offset_nnodes(0:iproc-1))
+    off = sum(offset_nnodes(0:iproc-1))
 
     ! prepare a temporal array to be recorded in hdf5
     ! element corner indices
@@ -665,26 +670,26 @@ subroutine write_partition_database_h5(iproc, nspec, elmnts, &
         ! elm_conn_xdmf
         if (NGNOD == 8) then
           elm_conn_xdmf(1,count) = 9 ! cell type id xdmf
-          elm_conn_xdmf(2,count) = loc_nodes(0)+o!+1 elm id starts 0
-          elm_conn_xdmf(3,count) = loc_nodes(1)+o
-          elm_conn_xdmf(4,count) = loc_nodes(2)+o
-          elm_conn_xdmf(5,count) = loc_nodes(3)+o
-          elm_conn_xdmf(6,count) = loc_nodes(4)+o
-          elm_conn_xdmf(7,count) = loc_nodes(5)+o
-          elm_conn_xdmf(8,count) = loc_nodes(6)+o
-          elm_conn_xdmf(9,count) = loc_nodes(7)+o
+          elm_conn_xdmf(2,count) = loc_nodes(0)+off !+1 elm id starts 0
+          elm_conn_xdmf(3,count) = loc_nodes(1)+off
+          elm_conn_xdmf(4,count) = loc_nodes(2)+off
+          elm_conn_xdmf(5,count) = loc_nodes(3)+off
+          elm_conn_xdmf(6,count) = loc_nodes(4)+off
+          elm_conn_xdmf(7,count) = loc_nodes(5)+off
+          elm_conn_xdmf(8,count) = loc_nodes(6)+off
+          elm_conn_xdmf(9,count) = loc_nodes(7)+off
         else ! NGNOD = 27
          ! NGNOD = 27 array will not be used, only the 8 corner nodes
          ! are necessary for checkmesh visualization
           elm_conn_xdmf(1,count)  = 9 !50 ! cell type id xdmf
-          elm_conn_xdmf(2,count)  = loc_nodes(0)+o
-          elm_conn_xdmf(3,count)  = loc_nodes(1)+o
-          elm_conn_xdmf(4,count)  = loc_nodes(2)+o
-          elm_conn_xdmf(5,count)  = loc_nodes(3)+o
-          elm_conn_xdmf(6,count)  = loc_nodes(4)+o
-          elm_conn_xdmf(7,count)  = loc_nodes(5)+o
-          elm_conn_xdmf(8,count)  = loc_nodes(6)+o
-          elm_conn_xdmf(9,count)  = loc_nodes(7)+o
+          elm_conn_xdmf(2,count)  = loc_nodes(0)+off
+          elm_conn_xdmf(3,count)  = loc_nodes(1)+off
+          elm_conn_xdmf(4,count)  = loc_nodes(2)+off
+          elm_conn_xdmf(5,count)  = loc_nodes(3)+off
+          elm_conn_xdmf(6,count)  = loc_nodes(4)+off
+          elm_conn_xdmf(7,count)  = loc_nodes(5)+off
+          elm_conn_xdmf(8,count)  = loc_nodes(6)+off
+          elm_conn_xdmf(9,count)  = loc_nodes(7)+off
 !          elm_conn_xdmf(10,count) = loc_nodes(8)
 !          elm_conn_xdmf(11,count) = loc_nodes(9)
 !          elm_conn_xdmf(12,count) = loc_nodes(10)
@@ -985,7 +990,7 @@ subroutine write_moho_surface_database_h5(iproc, nspec, &
   integer                     :: loc_nspec2D_moho
 
   ! for loc_nspec_2d_homo attribute
-  character(len=8)               :: aname = "loc_moho"
+  character(len=8), parameter :: aname = "loc_moho"
   integer         , dimension(2) :: moho_attr
 
   ! homo_elements dataset

src/generate_databases/fault_generate_databases.f90

@@ -347,7 +347,7 @@ subroutine setup_Kelvin_Voigt_eta(fdb,nspec)
     Kelvin_Voigt_eta(fdb%ispec2) = fdb%eta
   endif
 
- end subroutine
+ end subroutine setup_Kelvin_Voigt_eta
 
 !===============================================================================================================
 

src/generate_databases/get_coupling_surfaces.f90

@@ -981,4 +981,4 @@ integer function get_iglob_index(ijk_index,ispec_in,nspec,ibool)
   kk = ijk_index(3)
   get_iglob_index = ibool(ii,jj,kk,ispec_in)
 
-  end function
+  end function get_iglob_index

src/generate_databases/model_coupled.f90

@@ -42,6 +42,8 @@
 
   module model_coupled_par
 
+  implicit none
+
   ! VM VM my model for DSM coupling
   double precision, dimension (:,:), allocatable :: vpv_1D,vsv_1D,density_1D
   double precision, dimension (:), allocatable :: zlayer

src/generate_databases/model_external_values.F90

@@ -44,6 +44,7 @@ module external_model
 ! ADD YOUR MODEL HERE
 !
 !---
+  implicit none
   integer, parameter :: dummy_size = 1
 
   ! only here to illustrate an example

src/generate_databases/model_salton_trough.f90

@@ -34,6 +34,8 @@
 
   module salton_trough_par
 
+  implicit none
+
   !  Salton Sea Gocad voxet
   integer, parameter :: GOCAD_ST_NU = 638, GOCAD_ST_NV = 219, GOCAD_ST_NW = 76
   double precision, parameter :: &