Share one duration formatter instead of seven copies

- Adds `helpers.seconds_to_hm` next to the existing `minutes_to_hhmm`, and
  points the seven hand-rolled `Xh Ym` blocks in podcast views, media
  details, both statistics aggregators and the podcast lookup API at it.
- Output is unchanged except for a zero-second duration in the statistics
  "longest episodes" lists, which now renders blank rather than "0m",
  matching what every view already did.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: elemated

src/api/fork_views_podcast.py

@@ -8,7 +8,7 @@
 from rest_framework import views as drf_views
 from rest_framework.response import Response
 
-from app import fork_services_podcast
+from app import fork_services_podcast, helpers
 from app.forms import PodcastShowTrackerForm
 from app.log_safety import safe_url
 from app.models import PodcastEpisode, PodcastShow, PodcastShowTracker, Status
@@ -174,20 +174,6 @@ class PodcastLookupView(drf_views.APIView):
     # week in pocketcasts.lookup_by_itunes_id.
     _FEED_CACHE_SECONDS = 15 * 60
 
-    @staticmethod
-    def _format_duration(seconds):
-        """Format a duration in seconds as "1h 9m" or "46m".
-
-        Matches the format `podcast_views.py` sends for every already-imported
-        episode, so a preview episode's duration reads the same as a tracked
-        one's.
-        """
-        if not seconds:
-            return ""
-        hours = seconds // 3600
-        minutes = (seconds % 3600) // 60
-        return f"{hours}h {minutes}m" if hours > 0 else f"{minutes}m"
-
     def _read_feed(self, itunes_id, itunes_data, rss_feed_url):
         """Return (metadata, episodes) for a feed, caching the pair briefly."""
         cache_key = f"podcast_lookup_feed_{itunes_id}"
@@ -215,7 +201,7 @@ def _feed_episodes(self, rss_feed_url):
             {
                 "title": episode.get("title", ""),
                 "published": episode.get("published"),
-                "duration": self._format_duration(episode.get("duration")),
+                "duration": helpers.seconds_to_hm(episode.get("duration")),
                 "duration_seconds": episode.get("duration"),
                 "episode_number": episode.get("episode_number"),
                 "season_number": episode.get("season_number"),

src/app/helpers.py

@@ -75,6 +75,18 @@ def minutes_to_hhmm(total_minutes):
     return f"{hours}h {minutes:02d}min"
 
 
+def seconds_to_hm(total_seconds):
+    """Convert a duration in seconds to "1h 9m", or to "46m" under an hour.
+
+    Returns "" for a missing or zero duration.
+    """
+    if not total_seconds:
+        return ""
+    hours = total_seconds // 3600
+    minutes = (total_seconds % 3600) // 60
+    return f"{hours}h {minutes}m" if hours else f"{minutes}m"
+
+
 def has_real_image(image):
     """Return whether the value is a usable artwork URL."""
     return bool(image and image != settings.IMG_NONE)

src/app/media_details_views.py

@@ -488,15 +488,7 @@ def _best_effort_detail_followup(
             for episode_obj, enriched in zip(
                 episodes[:initial_limit], enriched_episodes, strict=False
             ):
-                # Format duration
-                duration_str = ""
-                if episode_obj.duration:
-                    hours = episode_obj.duration // 3600
-                    minutes = (episode_obj.duration % 3600) // 60
-                    if hours > 0:
-                        duration_str = f"{hours}h {minutes}m"
-                    else:
-                        duration_str = f"{minutes}m"
+                duration_str = helpers.seconds_to_hm(episode_obj.duration)
 
                 # Get user's podcast media for this episode
                 episode_media = enriched["media"]

src/app/podcast_views.py

@@ -174,11 +174,7 @@ def podcast_episodes_api(request, show_id):
                     enriched = e
                     break
 
-            duration_str = ""
-            if episode_obj.duration:
-                hours = episode_obj.duration // 3600
-                minutes = (episode_obj.duration % 3600) // 60
-                duration_str = f"{hours}h {minutes}m" if hours > 0 else f"{minutes}m"
+            duration_str = helpers.seconds_to_hm(episode_obj.duration)
 
             user_podcast = episode_podcast_map.get(episode_obj.id)
 
@@ -308,11 +304,7 @@ def count(self):
                 enriched = e
                 break
 
-        duration_str = ""
-        if episode_obj.duration:
-            hours = episode_obj.duration // 3600
-            minutes = (episode_obj.duration % 3600) // 60
-            duration_str = f"{hours}h {minutes}m" if hours > 0 else f"{minutes}m"
+        duration_str = helpers.seconds_to_hm(episode_obj.duration)
 
         user_podcast = episode_podcast_map.get(episode_obj.id)
         status = user_podcast.status if user_podcast else None
@@ -585,11 +577,7 @@ def podcast_save(request):
             else {"item": {"media_id": episode_obj.episode_uuid}, "media": None}
         )
 
-        duration_str = ""
-        if episode_obj.duration:
-            hours = episode_obj.duration // 3600
-            minutes = (episode_obj.duration % 3600) // 60
-            duration_str = f"{hours}h {minutes}m" if hours > 0 else f"{minutes}m"
+        duration_str = helpers.seconds_to_hm(episode_obj.duration)
 
         all_history = []
         if user_podcast:

src/app/statistics_aggregator.py

@@ -1380,9 +1380,7 @@ def _top_items(values, key_fields=("minutes", "plays"), limit=STATISTICS_TOP_N):
     for item in most_played + most_listened:
         item["formatted_duration"] = helpers.minutes_to_hhmm(item["minutes"])
     for item in longest_episodes:
-        hours = item["duration_seconds"] // 3600
-        minutes = (item["duration_seconds"] % 3600) // 60
-        item["formatted_duration"] = f"{hours}h {minutes}m" if hours else f"{minutes}m"
+        item["formatted_duration"] = helpers.seconds_to_hm(item["duration_seconds"])
     podcast_consumption.update(
         {
             "most_played": most_played,

src/app/stats_podcast.py

@@ -156,7 +156,7 @@ def _compute_podcast_top_lists(play_details, limit=STATISTICS_TOP_N):
     Returns:
         dict with most_played (by show), most_listened (by show), longest_episodes lists
     """
-    from app.helpers import minutes_to_hhmm
+    from app.helpers import minutes_to_hhmm, seconds_to_hm
 
     # Aggregate by show for most_played and most_listened
     show_stats = defaultdict(
@@ -298,12 +298,7 @@ def _compute_podcast_top_lists(play_details, limit=STATISTICS_TOP_N):
 
     # Format longest episodes duration (from seconds)
     for item in longest_episodes:
-        hours = item["duration_seconds"] // 3600
-        minutes = (item["duration_seconds"] % 3600) // 60
-        if hours > 0:
-            item["formatted_duration"] = f"{hours}h {minutes}m"
-        else:
-            item["formatted_duration"] = f"{minutes}m"
+        item["formatted_duration"] = seconds_to_hm(item["duration_seconds"])
 
     return {
         "most_played": most_played,