Validation

Author: danog

schemas

@@ -86,6 +86,25 @@
             ],
             "type": "TraverseParam"
         },
+        {
+            "id": "-39194058",
+            "predicate": "traverseMethodResult",
+            "params": [
+                {
+                    "name": "name",
+                    "type": "string"
+                },
+                {
+                    "name": "push_sources",
+                    "type": "Vector<Source>"
+                },
+                {
+                    "name": "is_needed_parent",
+                    "type": "Bool"
+                }
+            ],
+            "type": "TraverserIncoming"
+        },
         {
             "id": "1850540214",
             "predicate": "traverseIncomingConstructor",
@@ -136,25 +155,6 @@
             ],
             "type": "TraverserIncoming"
         },
-        {
-            "id": "-39194058",
-            "predicate": "traverseMethodResult",
-            "params": [
-                {
-                    "name": "name",
-                    "type": "string"
-                },
-                {
-                    "name": "push_sources",
-                    "type": "Vector<Source>"
-                },
-                {
-                    "name": "is_needed_parent",
-                    "type": "Bool"
-                }
-            ],
-            "type": "TraverserIncoming"
-        },
         {
             "id": "-584595818",
             "predicate": "source",

src/TL_file_ref_map_schema.json

@@ -10,9 +10,9 @@ fileReferenceMap#72a99250 layer:int db_schema:string db_schema_json:string trave
 // Traversers (incoming)
 traverseParam#62161b67 flags:# name:string is_flag:flags.0?true is_vector:flags.1?true type:string = TraverseParam;
 
+traverseMethodResult#fda9f236 name:string push_sources:Vector<Source> is_needed_parent:Bool = TraverserIncoming;
 traverseIncomingConstructor#6e4d00b6 type:string predicate:string params:Vector<TraverseParam> push_sources:Vector<Source> is_needed_parent:Bool = TraverserIncoming;
 traverseCommitSourceLocation#94cc59c5 type:string predicate:string push_sources:Vector<Source> stored_constructor:string = TraverserIncoming;
-traverseMethodResult#fda9f236 name:string push_sources:Vector<Source> is_needed_parent:Bool = TraverserIncoming;
 
 source#dd27c696 flags:# predicate:string is_constructor:flags.0?true stored_constructor:string stored_params:Vector<FieldExtractor> skipped_flags:Vector<string> needs_parent:flags.3?string parent_is_constructor:flags.4?true = Source;
 

src/TL_file_ref_map_schema.tl

@@ -839,10 +839,13 @@ public static function fixupTraversalPairs(Ast $output, TLWrapper $TL, array $lo
                     Assert::false($hasReturn, "Constructor $cons has a return value, cannot be used in incoming traversal");
                     Assert::notEmpty($newFields, "Constructor $cons does not have fields in traversal pairs but is used as a constructor");
 
+                    $consT = $TL->getConstructorOrMethod($cons)['type'];
+                    Assert::notEq($consT, 'Updates', "Constructor $cons has type Updates, cannot be used in incoming traversal as it is not a message/container constructor");
+
                     $fixed[] = [
                         '_' => 'traverseIncomingConstructor',
                         'predicate' => $cons,
-                        'type' => $TL->getConstructorOrMethod($cons)['type'],
+                        'type' => $consT,
                         'params' => $newFields,
                         'push_sources' => $sources[$cons] ?? [],
                         'is_needed_parent' => isset($parents[$cons]),