Removed backtracking for friend classes since it's not supported in PHP 7.0

Author: danrevah

.travis.yml

@@ -1,6 +1,7 @@
 language: php
 
 php:
+  - 7.0
   - 5.6
   - 5.5
   - 5.4

README.md

@@ -17,6 +17,8 @@
 
 ## Installation
 
+> PHP Version >= 5.4 is required! 
+
 The following instructions outline installation using Composer. If you don't
 have Composer, you can download it from [http://getcomposer.org/](http://getcomposer.org/)
 

src/ShortifyPunit.php

@@ -56,22 +56,8 @@ class ShortifyPunit
      */
     private static $returnValues = [];
 
-
-    /**
-     * @var array of allowed friend classes, that could access private methods of this class
-     */
-    private static $friendClasses = [
-        'ShortifyPunit\ShortifyPunit',
-        'ShortifyPunit\Stub\WhenCase',
-        'ShortifyPunit\Mock\MockClassOnTheFly',
-        'ShortifyPunit\Stub\WhenChainCase'];
-
     /**
      * Call static function is used to detect calls to protected & private methods
-     * only friend classes are allowed to call private methods (C++ Style)
-     *
-     * + Friend Classes are those who Implement the mocking interface (ShortifyPunitMockInterface)
-     *   or is set in $friendClasses variable
      *
      * @param $name
      * @param $arguments
@@ -88,22 +74,6 @@ public static function __callStatic($name, $arguments)
             throw self::generateException("{$class} has no such method!");
         }
 
-        $namespace = self::$namespace;
-        $backTrace = debug_backtrace();
-        $callingClassName = $backTrace[2]['class'];
-        
-        $reflection = new \ReflectionClass($callingClassName);
-
-        if ($reflection->implementsInterface("{$namespace}\\Mock\\MockInterface") &&
-            is_array($arguments)
-        ) {
-            $arguments[0] = $callingClassName;
-        }
-
-        if ( ! self::isFriendClass($callingClassName, $namespace)){
-            throw self::generateException("{$class} is not a friend class!");
-        }
-
         return forward_static_call_array('static::'.$name, $arguments);
     }
 
@@ -267,7 +237,7 @@ protected static function _isMethodStubbed($className, $instanceId, $methodName)
     }
 
     /**
-     * Setting up a chained mock response, function is called from mocked classes using `friend classes` style
+     * Setting up a chained mock response, function is called from mocked classes
      *
      * @param $mockClassInstanceId
      * @param $mockClassType
@@ -315,7 +285,7 @@ protected static function _createChainResponse(
 
 
     /**
-     * Setting up a mock response, function is called from mocked classes using `friend classes` style
+     * Setting up a mock response, function is called from mocked classes
      *
      * @param $className
      * @param $instanceId
@@ -341,7 +311,7 @@ protected static function _setWhenMockResponse(
     }
 
     /**
-     * Generating instance id, function is called from mocked classes using `friend classes` style
+     * Generating instance id, function is called from mocked classes
      * @return int
      */
     protected static function _generateInstanceId()
@@ -350,7 +320,7 @@ protected static function _generateInstanceId()
     }
 
     /**
-     * Create response is a private method which is called from the Mocked classes using `friend classes` style
+     * Create response is a private method which is called from the Mocked classes
      * returns a value which was set before in the When() function otherwise returning NULL
      *
      * @param $className
@@ -417,23 +387,6 @@ private static function getMockReflection($mockedClass)
         return $reflection;
     }
 
-    /**
-     * @param $callingClassName
-     * @param string $namespace
-     * @return bool
-     */
-    private static function isFriendClass($callingClassName, $namespace)
-    {
-        $reflection = new \ReflectionClass($callingClassName);
-
-        if ( ! $reflection->implementsInterface("{$namespace}\\Mock\\MockInterface") &&
-             ! in_array($callingClassName, self::$friendClasses)) {
-            return false;
-        }
-
-        return true;
-    }
-
     /**
      * Returns the mock hierarchy response values
      *

tests/ShortifyPunitTest.php

@@ -91,15 +91,6 @@ public function testStubbingNullIfNotSet()
         $this->assertNull($mock->second_method());
     }
 
-    /**
-     * @checks Friend classes
-     * @expectedException \PHPUnit_Framework_AssertionFailedError
-     */
-    public function testFriendClasses()
-    {
-        ShortifyPunit::generateInstanceId();
-    }
-
     /**
      * @checks Private method exist
      * @expectedException \PHPUnit_Framework_AssertionFailedError

tests/Verify/VerifyTest.php

@@ -141,4 +141,4 @@ public function testWithHamcrestMatcher()
         $this->assertFalse(ShortifyPunit::verify($mock)->bar(1)->foo(2)->calledTimes(2));
         $this->assertFalse(ShortifyPunit::verify($mock)->bar(1)->foo(2)->lessThan(1));
     }
-} 
+}