-
Notifications
You must be signed in to change notification settings - Fork 324
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Currently, releasing a new version of e.g. dapp requires:
- updating the nix package
- updating
dapp --version
- updating the
CHANGELOG
- pushing a git tag
This is error-prone and has already resulted in a few mistakes.
One way to walk towards a more manageable solution is to institute a VERSION
file for each tool, read by both the nix package and the --version
subcommand. This would allow us to eliminate the first two steps above.
A next step could be to create a script that bumps the version in VERSION
and performs operations/sanity checks:
- adds a section to the changelog
- creates a branch named
dapp/x.y.z
- ...
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
asymmetric commentedon Mar 8, 2019
I realized there's a problem with the
VERSION
file:VERSION
file to the store. We could, but I think a better approach is to insert its contents insidedapp---version
.Makefile
directly, this would break.Which begs the question of if we still want to support installation with
make
.desaperados commentedon Mar 9, 2019
Agree that a single source of truth would make versioning more manageable. Could we somehow use the latest git tag?
asymmetric commentedon Mar 9, 2019
I mean we could come up with a script that takes in the program (e.g. "dapp") and the new version as inputs and bumps them everywhere. Could work. Might be a bit messy/brittle though.
Also I think the tag should be added when the branch is merged on master, not on the side branch, so we'd still have to take care of that separately.
d-xo commentedon Mar 20, 2019
Some notes I took when upgrading the
solc
version, maybe relevant for any future automation work:dapphub/nixpkgs:master
tonixos/nixpkgs:master
solc-X.Y.Z
) fromdapphub/nixpkgs:master
pkgs/development/compilers/solc/default.nix
version
toX.Y.Z
rev
andsha256
based on the output fromnix-prefetch-git git@github.com:ethereum/solidity.git vX.Y.Z
nix-build -A solc
from the repo rootnix-env -f . -iA solc
) and run a fewtests to make sure everything is OK.
solc-X.Y.Z
) indapphub/dapptools
nix/solc-versions.nix
solc_X.Y.Z
in theunreleased
sectionrev
andsha256
based on the output fromnix-prefetch-git git@github.com:dapphub/nixpkgs refs/heads/solc-X.Y.Z
dapp---version
,default.nix
and the changelogdapphub/dapptools:solc-X.Y.Z
todapphub/dapptools:master
dapphub/nixpkgs:solc-X.Y.Z
tonixos/nixpkgs:master
dapphub/dapptools
moving thesolc_X.Y.Z
from theunreleased
to thedarwin
section insolc-versions.nix
asymmetric commentedon Jan 4, 2020
A couple of ideas for GitHub bots: