Skip to content

[Feature Request] Allow Receiving Cumulative Vote Rewards While Offline #91

@UnknownSilicon

Description

@UnknownSilicon

The check cumulative functions (checkDailyCumulative, checkWeeklyCumulative, etc.) in

fun checkDailyCumulative(player: Player)
are only called when a player is online due to this check
val online = player.player ?: return

Since the cumulative checks only see if the player has exactly the correct amount of votes, players do not receive cumulative rewards if they were offline for the last vote. This could be fixed in one of two ways:

  1. Keep track of the cumulative rewards a player did receive and change the cumulative check to check for greater than or equal to the required amount of votes.
  2. Add cumulative rewards to a player's claimable, redeeming them when the player next joins (as shown in this commit ParallelMC@084d78f. This exact solution isn't clean, but it may end up being less data to track).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions