workspace: Do not depends on the library*.db order.

We make sure that default and memory DB are first added and then
we list the others. This ensure that library.db (default) is present
when adding the other workspace and avoid a crash due to null
access.

Closes #20140.

Author: TurboGit

src/gui/workspace.c

@@ -170,56 +170,45 @@ gboolean dt_workspace_create(const char *datadir)
 
   gtk_window_set_position(GTK_WINDOW(session->db_screen), GTK_WIN_POS_CENTER);
 
-  GList *dbs = dt_read_file_pattern(datadir, "library*.db");
+  GList *dbs = dt_read_file_pattern(datadir, "library-*.db");
 
   GtkWidget *l1 = gtk_label_new(_("select an existing workspace"));
   dt_gui_dialog_add(session->db_screen, l1);
 
   const char *current_db =  dt_conf_get_string("database");
-  gboolean current_db_found = FALSE;
+  gboolean current_db_found = strcmp("default", current_db) == 0 ? TRUE : FALSE;
 
+  // add default workspace
+  GtkBox *box = _insert_button(session, _("default"));
+  // add a memory workspace just after default one
+  box = _insert_button(session, _("memory"));
+
+  // add now only the non default libraries
   for(GList *l = g_list_first(dbs); l; l = g_list_next(l))
   {
     char *name = (char *)l->data;
-    const gboolean is_default = strcmp(name, "library.db") == 0;
-    GtkBox *box = NULL;
 
-    if(is_default)
-    {
-      box = _insert_button(session, _("default"));
-    }
-    else if(g_str_has_prefix(name, "library-"))
-    {
-      // skip "library-" prefix
-      char *f = name + strlen("library") + 1;
-      // end with the dot
-      char *e = f;
-      while(*e != '.') e++;
-      *e = '\0';
-
-      box = _insert_button(session, f);
-    }
+    // skip "library-" prefix
+    char *f = name + strlen("library") + 1;
+    // end with the dot
+    char *e = f;
+    while(*e != '.') e++;
+    *e = '\0';
+
+    box = _insert_button(session, f);
 
     if(strcmp(name, current_db) == 0)
       current_db_found = TRUE;
 
-    if(is_default)
-    {
-      // add a memory workspace just after default one
-      box = _insert_button(session, _("memory"));
-    }
-    else if(!is_default)
-    {
-      GList *bc = gtk_container_get_children(GTK_CONTAINER(box));
-      GtkWidget *b = (GtkWidget *)g_list_first(bc)->data;
-      g_list_free(bc);
-
-      GtkWidget *del = dtgtk_button_new(dtgtk_cairo_paint_remove, 0, NULL);
-      g_signal_connect(G_OBJECT(del), "clicked",
-                       G_CALLBACK(_workspace_delete_db), session);
-      g_object_set_data(G_OBJECT(del), "db", b);
-      dt_gui_box_add(box, del);
-    }
+    GList *bc = gtk_container_get_children(GTK_CONTAINER(box));
+    GtkWidget *b = (GtkWidget *)g_list_first(bc)->data;
+    g_list_free(bc);
+
+    GtkWidget *del = dtgtk_button_new(dtgtk_cairo_paint_remove, 0, NULL);
+    g_signal_connect(G_OBJECT(del), "clicked",
+                     G_CALLBACK(_workspace_delete_db), session);
+    g_object_set_data(G_OBJECT(del), "db", b);
+    dt_gui_box_add(box, del);
   }
 
   g_list_free_full(dbs, g_free);
@@ -233,7 +222,7 @@ gboolean dt_workspace_create(const char *datadir)
 
   GtkWidget *l2 = gtk_label_new(_("or create a new one"));
 
-  GtkBox *box = GTK_BOX(dt_gui_hbox());
+  box = GTK_BOX(dt_gui_hbox());
   session->entry = gtk_entry_new();
   g_signal_connect(G_OBJECT(session->entry),
                    "changed", G_CALLBACK(_workspace_entry_changed), session);