Segfault when recalling an export module preset for JXL

[m-p-y]

Is there an existing issue for this?

• I checked and did not find my issue in the already reported ones

Describe the bug

When I recall a preset in the export module which should set the output file format to "JPEG XL", darktable crashes.

Steps to reproduce

1. Set "file format" to "JPEG XL" in "export module"
2. Save a new preset
3. Reset module
4. Recall the new preset from step 2.
5. Segfault

Expected behavior

Preset is applied, darktable not crashing ;)

Logfile | Screenshot | Screencast

Attached the automatic generated backtrace:
darktable_bt_XG75I3.txt

Commit

216b88b

Where did you obtain darktable from?

self compiled

darktable version

5.5.0+86~g34c63ee7d7

What OS are you using?

Linux

What is the version of your OS?

Arch Linux (rolling release)

Describe your system

OS: Arch Linux x86_64
Kernel: 6.18.4
Shell: zsh 5.9.0.2-test
Resolution: 1920x1080, 1920x1200
DE: Plasma 6.5.4
WM: KWin
WM Theme: Klassy
Theme: Breeze-Dunkel [Plasma], Breeze-Dark [GTK2/3]
Icons: klassy-dark [Plasma], klassy-dark [GTK2/3]
Terminal: urxvt

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

NVIDIA 590.48.01

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

I reverted commit 216b88b "Remove encoding color profile control" and darktable then behaved correctly. I still don't see the "color profile" control in the export module, which the commit seems to remove.

[TurboGit]

Can you please export your preset and attach it here? TIA.

[m-p-y]

No problem, here it is:
tmp_JXL.dtpreset.txt

The segfault is even easier to reproduce, as I just observed:

1. Switch to "JPEG XL" as "file format" in the export module
2. Press the Reset button on the export module
3. Segfault

[TurboGit]

Thanks for reporting, should be fixed now.

[m-p-y]

Thanks, it fixes the segfault when pressing the reset button.
Darktable still segfaults when using the preset.

Now, that I knew what to look for, I was able to fix the latter with this patch:
#20130

I hope this is the correct approach and doing a PR for such a small change is sensible.