feat(cli): Bun-first CLI migration with 7 commands and comprehensive test suite (#259)

* feat(cli): migrate packages/cli to Bun-first with full test suite

- Replace fs-extra with Bun.file/Bun.write/node:fs/promises across all 9 source files
- Fix --help fast-path so all 8 subcommands are visible
- Replace tsup/tsx/vitest with bun build/bun run/bun:test
- Replace __dirname with import.meta.dir; use JSON import assertion for version
- Fix hardcoded OAC_VERSION in add.ts; add hashesMatch import to status.ts
- Replace computeFileHash with Bun.file().bytes() in sha256.ts
- Rename checkNodeVersion → checkBunVersion; parallelise doctor checks
- Fix TypeScript void-inference errors in update.ts, list.ts, status.ts
  by replacing .catch() with let/try-catch where result is used downstream
- Add ManifestError named error class; remove unsafe type casts
- Add 43 bun:test unit tests (sha256, manifest, installer, version) — 0 failures

* fix(cli): resolve critical bugs and standards violations found in review

Critical bug fixes:
- ide-detect.ts: replace Bun.file(dir).exists() with stat().isDirectory()
  for all directory checks — Bun.file().exists() always returns false for
  directories, breaking Cursor/Windsurf/OpenCode/Claude detection entirely
- bundled.ts: add registry.json exclusion anchor to findPackageRoot() to
  prevent monorepo root from matching before the CLI package root

Standards cleanup (§4.1, §5.1, §6.1, §15.3, §21.1):
- status.ts: parallelise findModifiedFiles + detectIdes with Promise.all
- apply.ts: fix duplicate warn/limit messages; remove else after return in
  reportWarnings; remove redundant mkdir before Bun.write
- version.ts: remove unnecessary (pkgJson as {version?:string}) cast
- manifest.ts: remove redundant mkdir before Bun.write; remove as unknown cast
- installer.ts: remove redundant mkdir calls before Bun.write throughout
- add.ts: add comment explaining why node:fs/promises rm is used

Tests (43 → 142, +99 new tests across 4 new files):
- ide-detect.test.ts: 26 tests covering all 4 IDEs, both claude indicators,
  detectIdes parallel, isIdePresent — directly validates the directory fix
- bundled.test.ts: 27 tests for classifyBundledFile, findPackageRoot,
  listBundledFiles, getBundledFilePath, bundledFileExists
- config.test.ts: 25 tests for readConfig/writeConfig round-trips,
  createDefaultConfig, mergeConfig, isYoloMode, isAutoBackup
- installer-update.test.ts: 14 tests covering all 5 updateFiles decision
  branches (install/update/skip/yolo/dry-run) plus isProjectRoot
- sha256.test.ts: +4 tests for empty file, large file, binary content

* fix(cli): fix P0 bugs — global flags, .git detection, package root resolution

- Remove duplicate --dry-run/--yolo/--verbose from parent program; Commander.js
  global option stealing caused all safety flags to be silently dropped in every
  subcommand action callback
- Fix isProjectRoot() to use stat() for .git detection; Bun.file().exists()
  returns false for directories, breaking oac init in standard git repos
- Add OAC_PACKAGE_ROOT env var override to getPackageRoot() for dev/monorepo mode;
  registry.json heuristic excluded the repo root causing oac init/add/update to
  throw when run from source
- Fix build script: remove --banner flag that caused double shebang in dist/index.js
- Rewrite bin/oac.js to invoke bun instead of node (dist is bun-only target)
- Refactor installer.ts let accumulators to const using Promise.all + reduce
- Add MVP planning docs (00-MVP-PLAN.md, master synthesis, project breakdown)

* fix(install.sh): handle both singular and plural component type formats

The get_registry_key() function was always adding 's' to the type,
causing 'contexts' to become 'contextss' which doesn't exist in registry.json.

Now handles:
- Singular forms: context → contexts, agent → agents, skill → skills
- Plural forms: contexts → contexts (unchanged), agents → agents
- Config stays singular
- Fallback for any type ending in 's'

Fixes #257

Author: darrenhinde

bin/oac.js

@@ -1,90 +1,23 @@
 #!/usr/bin/env node
+'use strict';
 
-/**
- * OpenAgents Control (OAC) CLI
- * 
- * This is the main entry point for the @openagents/control package.
- * It runs the install.sh script to set up the OpenAgents Control system.
- */
-
-const { spawn } = require('child_process');
+const { execFileSync } = require('child_process');
 const path = require('path');
 const fs = require('fs');
 
-// Get the package root directory
-const packageRoot = path.join(__dirname, '..');
-
-// Path to install.sh
-const installScript = path.join(packageRoot, 'install.sh');
+const cliDist = path.join(__dirname, '..', 'packages', 'cli', 'dist', 'index.js');
 
-// Check if install.sh exists
-if (!fs.existsSync(installScript)) {
-  console.error('Error: install.sh not found at', installScript);
+if (!fs.existsSync(cliDist)) {
+  console.error('Error: OAC CLI not built yet. Run: npm run build -w packages/cli');
   process.exit(1);
 }
 
-// Get command line arguments (skip node and script path)
-const args = process.argv.slice(2);
-
-// If no arguments provided, show help
-if (args.length === 0) {
-  console.log(`
-╔═══════════════════════════════════════════════════════════════╗
-║                  OpenAgents Control (OAC)                     ║
-║   AI agent framework for plan-first development workflows     ║
-╚═══════════════════════════════════════════════════════════════╝
-
-Usage:
-  oac [profile]           Install with a specific profile
-  oac --help             Show this help message
-  oac --version          Show version information
-
-Available Profiles:
-  essential              Minimal setup (OpenAgent only)
-  developer              Full development setup (recommended)
-  business               Business-focused agents
-  advanced               Advanced features and specialists
-  full                   Everything included
-
-Examples:
-  oac                    Interactive installation
-  oac developer          Install with developer profile
-  oac --help            Show detailed help
-
-For more information, visit:
-  https://github.com/darrenhinde/OpenAgentsControl
-`);
-  process.exit(0);
-}
-
-// Handle --version flag
-if (args.includes('--version') || args.includes('-v')) {
-  const packageJson = require(path.join(packageRoot, 'package.json'));
-  console.log(`@openagents/control v${packageJson.version}`);
-  process.exit(0);
-}
-
-// Handle --help flag
-if (args.includes('--help') || args.includes('-h')) {
-  // Run install.sh with --help
-  args.push('--help');
-}
-
-// Run the install script with bash
-const child = spawn('bash', [installScript, ...args], {
-  cwd: packageRoot,
-  stdio: 'inherit',
-  env: {
-    ...process.env,
-    OAC_PACKAGE_ROOT: packageRoot
+try {
+  execFileSync('bun', [cliDist, ...process.argv.slice(2)], { stdio: 'inherit' });
+} catch (err) {
+  if (err.code === 'ENOENT') {
+    console.error('Error: Bun is required to run OAC CLI. Install from https://bun.sh');
+    process.exit(1);
   }
-});
-
-child.on('error', (error) => {
-  console.error('Error running install script:', error.message);
-  process.exit(1);
-});
-
-child.on('exit', (code) => {
-  process.exit(code || 0);
-});
+  process.exitCode = err.status ?? 1;
+}

bun.lock

@@ -7,7 +7,15 @@
 
 ---
 
-## 📁 Planning Documents
+## 🎯 MVP Plan (START HERE)
+
+**`mvp/00-MVP-PLAN.md`** — The 20% that delivers 80% of the value.
+5 commands, 6 weeks, focused on what users actually care about.
+This is what we build first. Everything else is v1.1+.
+
+---
+
+## 📁 Full Planning Documents (Reference)
 
 ### Core Planning