Skip to content

Commit e184b26

Browse files
author
shanedsnyder
authored
Merge pull request #810 from tylerjereddy/treddy_issue_479
MAINT: unpin matplotlib
2 parents 5934e41 + 3316994 commit e184b26

File tree

4 files changed

+14
-9
lines changed

4 files changed

+14
-9
lines changed

.cirrus.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ task:
88
/opt/homebrew/opt/[email protected]/bin/python3 -m venv ~/py_310
99
source ~/py_310/bin/activate
1010
python -m pip install --upgrade pip
11-
python -m pip install --upgrade pytest lxml
12-
python -m pip install 'matplotlib<3.5'
11+
python -m pip install --upgrade pytest lxml matplotlib packaging
1312
brew install automake libtool binutils
1413
mkdir -p /tmp/darshan_install
1514
export DARSHAN_INSTALL_PATH=/tmp/darshan_install

.github/workflows/main_ci.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ jobs:
3131
- name: Install dependencies
3232
run: |
3333
python -m pip install --upgrade pip
34-
python -m pip install --upgrade pytest mypy pyflakes asv pytest-cov codecov lxml
35-
# matplotlib is pinned because of
36-
# gh-479
37-
python -m pip install 'matplotlib<3.5'
34+
python -m pip install --upgrade pytest mypy pyflakes asv pytest-cov codecov lxml matplotlib packaging
3835
- if: ${{matrix.platform == 'macos-latest'}}
3936
name: Install MacOS deps
4037
run: |

darshan-util/pydarshan/darshan/tests/test_plot_dxt_heatmap.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
from numpy.testing import assert_array_equal, assert_allclose
44
import pandas as pd
55
import seaborn as sns
6+
import matplotlib
67
import matplotlib.pyplot as plt
8+
from packaging import version
79

810
import darshan
911
from darshan.experimental.plots import heatmap_handling, plot_dxt_heatmap
@@ -389,10 +391,16 @@ def test_adjust_for_colorbar(filepath):
389391
# since `dxt.darshan` has 1 rank, the colorbar doesn't have
390392
# to go closer to the edge of the figure
391393
assert cbar_positions.x0 == 0.82
392-
assert cbar_positions.x1 == 0.8416135084427767
394+
if version.parse(matplotlib.__version__) < version.parse("3.5.0"):
395+
assert cbar_positions.x1 == 0.8416135084427767
396+
else:
397+
assert cbar_positions.x1 == 1.72
393398
else:
394399
assert cbar_positions.x0 == 0.85
395-
assert cbar_positions.x1 == 0.8716135084427767
400+
if version.parse(matplotlib.__version__) < version.parse("3.5.0"):
401+
assert cbar_positions.x1 == 0.8716135084427767
402+
else:
403+
assert cbar_positions.x1 == 1.75
396404

397405
@pytest.mark.parametrize(
398406
"filepath",

darshan-util/pydarshan/pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ skip = [
1414
"*_s390x"
1515
]
1616
test-requires = [
17+
"packaging",
1718
"pytest",
1819
"lxml",
19-
"matplotlib<3.5",
20+
"matplotlib",
2021
"importlib_resources;python_version<'3.9'"
2122
]
2223
before-test = "pip install -U git+https://github.com/darshan-hpc/darshan-logs.git@main"

0 commit comments

Comments
 (0)