deprecate wrapper generators #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I can see the only conflict is the changes to file |
wkliao
force-pushed
the
carns/deprecate-wrapper-method
branch
from
505f4f1 to
75d04a6
Compare
carns
force-pushed
the
carns/deprecate-wrapper-method
branch
from
75d04a6 to
b8b51ad
Compare
Author
|
I think this is up to date now. I'll open a separate PR to remove the old .txt documentation files; they aren't needed now that we have fully migrated to RTD. |
wkliao
reviewed
Sep 15, 2025
Collaborator
wkliao
left a comment
wkliao
left a comment
There was a problem hiding this comment.
File darshan-runtime/Makefile.am contains the followings lines that need to be removed.
They cause Github CI actions to fail.
darshan-gen-cc.pl \
darshan-gen-cxx.pl \
darshan-gen-fortran.pl \
added 3 commits
September 16, 2025 11:20
- remove the generators themselves - refactor the runtime documentation a bit (remove discussion of wrapper generator scripts, reorganize remaining options into subsections in priority of Cray option, MPICH option, then manual option)
carns
force-pushed
the
carns/deprecate-wrapper-method
branch
from
d472421 to
54aa481
Compare
Author
Thanks! Fixed now. I also rebased to account for the removal of the .txt documents in the other PR. |
wkliao
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Darshan documentation still advocates for generating custom MPI compiler wrapper scripts with Darshan instrumentation. This method was developed for MPICH 2 and early versions of MPICH 3 and isn't really appropriate for any recent versions of MPICH. The profile method is far less fragile.
Note that this PR conflicts with #1033 probably. If that one lands first, I can revise this to update the rtd version of the documentation instead.