doc(cupertino_http): fix code examples (#1923)

Author: brianquinlan

pkgs/cupertino_http/CHANGELOG.md

@@ -1,5 +1,6 @@
 ## 3.0.1-wip
 
+* Fix some code examples.
 * Remove `README.md` text saying that the package is a Flutter plugin.
 
 ## 3.0.0

pkgs/cupertino_http/README.md

@@ -9,8 +9,8 @@ A macOS/iOS library that provides access to the
 Using the [Foundation URL Loading System][], rather than the socket-based
 [dart:io HttpClient][] implementation, has several advantages:
 
-1. It automatically supports iOS/macOS platform features such VPNs and HTTP
-   proxies. 
+1. It automatically supports iOS/macOS platform features such as VPNs and HTTP
+   proxies.
 2. It supports many more configuration options such as only allowing access
    through WiFi and blocking cookies.
 3. It supports more HTTP features such as HTTP/3 and custom redirect handling.
@@ -24,6 +24,8 @@ This approach allows the same HTTP code to be used on all platforms, while
 still allowing platform-specific setup.
 
 ```dart
+import 'dart:io';
+
 import 'package:cupertino_http/cupertino_http.dart';
 import 'package:http/http.dart';
 import 'package:http/io_client.dart';
@@ -43,6 +45,8 @@ void main() async {
       'www.googleapis.com',
       '/books/v1/volumes',
       {'q': 'HTTP', 'maxResults': '40', 'printType': 'books'}));
+
+  httpClient.close();
 }
 ```
 
@@ -81,8 +85,8 @@ final url = Uri.https(
 final session = URLSession.sharedSession();
 final task = session.dataTaskWithCompletionHandler(URLRequest.fromUrl(url),
     (data, response, error) {
-  if (error == null && response!.statusCode == 200) {
-    print(data!.bytes);
+  if (error == null && response is HTTPURLResponse && response.statusCode == 200) {
+    print(data!.toList());
   }
 });
 task.resume();

pkgs/cupertino_http/lib/cupertino_http.dart

@@ -17,6 +17,10 @@
 /// [CupertinoClient].
 ///
 /// ```
+/// import 'dart:convert';
+/// import 'dart:io';
+/// import 'dart:math';
+///
 /// import 'package:cupertino_http/cupertino_http.dart';
 ///
 /// void main() async {
@@ -35,6 +39,7 @@
 ///   for (var i = 0; i < min(itemCount, 10); ++i) {
 ///     print(decodedResponse['items'][i]['volumeInfo']['title']);
 ///   }
+///   client.close();
 /// }
 /// ```
 ///
@@ -43,6 +48,8 @@
 /// platform.
 ///
 /// ```
+/// import 'dart:io';
+///
 /// void main() {
 ///   final Client httpClient;
 ///   if (Platform.isIOS || Platform.isMacOS) {
@@ -75,7 +82,7 @@
 ///     URLRequest.fromUrl(url),
 ///       (data, response, error) {
 ///     if (error == null) {
-///       if (response != null && response.statusCode == 200) {
+///       if (response is HTTPURLResponse && response.statusCode == 200) {
 ///         print(response);  // Do something with the response.
 ///         return;
 ///       }

pkgs/cupertino_http/lib/src/cupertino_api.dart

@@ -14,7 +14,7 @@
 ///     URLRequest.fromUrl(url),
 ///       (data, response, error) {
 ///     if (error == null) {
-///       if (response != null && response.statusCode == 200) {
+///       if (response is HTTPURLResponse && response.statusCode == 200) {
 ///         print(response);  // Do something with the response.
 ///         return;
 ///       }

pkgs/cupertino_http/lib/src/cupertino_client.dart

@@ -59,6 +59,12 @@ class _StreamedResponseWithUrl extends StreamedResponse
 ///
 /// For example:
 /// ```
+/// import 'dart:convert';
+/// import 'dart:io';
+/// import 'dart:math';
+///
+/// import 'package:cupertino_http/cupertino_http.dart';
+///
 /// void main() async {
 ///   var client = CupertinoClient.defaultSessionConfiguration();
 ///   final response = await client.get(
@@ -75,6 +81,7 @@ class _StreamedResponseWithUrl extends StreamedResponse
 ///   for (var i = 0; i < min(itemCount, 10); ++i) {
 ///     print(decodedResponse['items'][i]['volumeInfo']['title']);
 ///   }
+///   client.close();
 /// }
 /// ```
 class CupertinoClient extends BaseClient {