pana incorrectly states that a platform isn't supported.

[bsutton]

I see a number of packages where pana incorrectly states that a supported platform is not supported.

https://pub.dev/packages/dcli/score

Package does not support platform `Linux`.
Because:

package:dcli/dcli.dart that imports:
package:dcli/src/util/string_as_process.dart that imports:
package:dcli/src/util/runnable_process.dart that imports:
package:dcli/src/process/process/process_in_isolate.dart that imports:
package:dcli/src/process/process/in_isolate/process_runner.dart that imports:
package:dcli_terminal/dcli_terminal.dart that imports:
package:dcli_terminal/src/terminal.dart that imports:
package:dart_console/dart_console.dart that imports:
package:dart_console/src/console.dart that imports:
package:dart_console/src/ffi/win/termlib_win.dart that imports:
package:win32/win32.dart that declares support for platforms: Windows.

Whilst the package does import windows libraries it has conditional code around those components so it does in fact support linux.

I understand what you are trying to do here, but false negatives like these can be damaging to a packages reputation.

[sigurdm]

Yeah - the platform detection is heuristic, only looking at the static shape of the code.

False negatives can be overridden by declaring platforms for the package itself: https://dart.dev/tools/pub/pubspec#platforms

[isoos]

package:dart_console/src/console.dart imports package:dart_console/src/ffi/win/termlib_win.dart directly, which imports win32, in that sense this is working as intended.

Note: I'm not sure, but IIRC the detection code handles some of the conditional imports. If it would import it conditionally, we would detect the linux platform support too. In the absence of that (or if the conditional import is not working as I remember it), declaring the platform as above should work.

[sigurdm]

conditional imports don't have access to the OS. You can separate web vs vm and wasm I believe...

[bsutton]

@sigurdm

False negatives can be overridden by declaring platforms for the package itself:

dcli already declares platforms:

platforms:
linux:
macos:
windows:

[isoos]

@sigurdm

False negatives can be overridden by declaring platforms for the package itself:

dcli already declares platforms:

platforms: linux: macos: windows:

We do use that declaration (see under the package name, the platform tags are there - also in the underlying report's tags entry).

While we accept the declaration from pubspec, we still run the platform analysis, and for platforms that can have conflicts, we emit an additional detail about potential incompatibility, with the note: These issues are present but do not affect the score, because they may not originate in your package: (and we make the platform score red, while not reducing it).

I'm not really sure if we should hide the note, it seems to be something that could be useful (maybe not in this specific case).

[sigurdm]

Yes! That seems to be a bug. If the package has a platforms declaration itself we we probably should not complain about it - or at least make it more clear that the complaints can be ignored.