Skip to content

Allow linter rule pass-through override for rules that are included from third-party ruleset but are not included in the package:lints defaults. #1499

@nielsenko

Description

@nielsenko

Testing pana score for latest relic with pana 0.22.23 I get a perfect score:

$> pana --exit-code-threshold=0 --hosted relic
...
Points: 160/160.

Running with 0.22.24

$> dart pub global activate pana 0.22.24
Package pana is currently active at version 0.22.23.
Downloading packages... . (1.2s)
> pana 0.22.24 (was 0.22.23)
Building package executables... 
Built pana:license_detector_bin.
Built pana:pana.
Built pana:batch.
Installed executable pana.
Activated pana 0.22.24.
$> pana --exit-code-threshold=0 --hosted relic

I get:

✗ Pass static analysis (40 / 50)

[~] 40/50 points: code has no errors, warnings, lints, or formatting issues

Found 562 issues. Showing the first 2:

INFO: Missing documentation for a public member.

lib/src/adapter/io/io_adapter.dart:65:7

   ╷
65 │ class IOAdapterRequest extends AdapterRequest {
   │       ^^^^^^^^^^^^^^^^
   ╵

To reproduce make sure you are using the lints_core and run dart analyze lib/src/adapter/io/io_adapter.dart

INFO: Missing documentation for a public member.

lib/src/adapter/io/io_adapter.dart:67:3

   ╷
67 │   IOAdapterRequest(this._httpRequest);
   │   ^^^^^^^^^^^^^^^^
   ╵

To reproduce make sure you are using the lints_core and run dart analyze lib/src/adapter/io/io_adapter.dart

Running dart analyze in the checked out repo finds no issues.

Reading the release note for 0.22.24 I don't really understand why this is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-enhancementA request for a change that isn't a bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions