Move hasMultipleVersions to Description (#4576)

Author: sigurdm

lib/src/command/add.dart

@@ -714,7 +714,7 @@ Specify multiple sdk packages with descriptors.''');
       final description = pubspecDescription(
         ref.withConstraint(
           constraint ??
-              (ref.source is HostedSource
+              (ref.description.hasMultipleVersions
                   ? VersionConstraint.compatibleWith(resultId.version)
                   : VersionConstraint.any),
         ),

lib/src/command/upgrade.dart

@@ -17,7 +17,6 @@ import '../package_name.dart';
 import '../pubspec.dart';
 import '../pubspec_utils.dart';
 import '../solver.dart';
-import '../source/hosted.dart';
 import '../utils.dart';
 
 /// Handles the `upgrade` pub command.
@@ -248,11 +247,11 @@ be direct 'dependencies' or 'dev_dependencies', following packages are not:
     // Mapping from original to changed value.
     var changes = <Package, Map<PackageRange, PackageRange>>{};
     for (final package in entrypoint.workspaceRoot.transitiveWorkspace) {
-      final declaredHostedDependencies = [
+      final declaredUpgradableDependencies = [
         ...package.dependencies.values,
         ...package.devDependencies.values,
-      ].where((dep) => dep.source is HostedSource);
-      for (final dep in declaredHostedDependencies) {
+      ].where((dep) => dep.description.hasMultipleVersions);
+      for (final dep in declaredUpgradableDependencies) {
         final resolvedPackage = resolvedPackages[dep.name]!;
         if (!toUpgrade.contains(dep.name)) {
           // If we're not trying to upgrade this package, or it wasn't in the

lib/src/package_name.dart

@@ -174,7 +174,7 @@ class PackageRange {
   bool get _showVersionConstraint {
     if (isRoot) return false;
     if (!constraint.isAny) return true;
-    return description.source.hasMultipleVersions;
+    return description.hasMultipleVersions;
   }
 
   /// Returns a copy of `this` with the same semantics, but with a `^`-style

lib/src/solver/version_solver.dart

@@ -586,7 +586,10 @@ class VersionSolver {
     // can't be downgraded.
     if (_type == SolveType.downgrade) {
       final locked = _lockFile.packages[package];
-      if (locked != null && !locked.source.hasMultipleVersions) return locked;
+      if (locked != null &&
+          !locked.description.description.hasMultipleVersions) {
+        return locked;
+      }
     }
 
     if (_unlock.isEmpty || _unlock.contains(package)) return null;

lib/src/source.dart

@@ -51,12 +51,6 @@ abstract class Source {
   /// all sources.
   String get name;
 
-  /// Whether this source can choose between multiple versions of the same
-  /// package during version solving.
-  ///
-  /// Defaults to `false`.
-  bool get hasMultipleVersions => false;
-
   /// Parses a [PackageRef] from a name and a user-provided [description].
   ///
   /// When a [Pubspec] is parsed, it reads in the description for each
@@ -190,6 +184,11 @@ abstract class Source {
 /// with a version constraint.
 abstract class Description {
   Source get source;
+
+  /// Whether the source can choose between multiple versions of this
+  /// package during version solving.
+  bool get hasMultipleVersions;
+
   Object? serializeForPubspec({
     required String? containingDir,
     required LanguageVersion languageVersion,

lib/src/source/git.dart

@@ -892,6 +892,9 @@ class GitDescription extends Description {
     }
     return p.prettyUri(url);
   }
+
+  @override
+  bool get hasMultipleVersions => false;
 }
 
 class ResolvedGitDescription extends ResolvedDescription {

lib/src/source/hosted.dart

@@ -123,8 +123,6 @@ class HostedSource extends CachedSource {
 
   @override
   final name = 'hosted';
-  @override
-  final hasMultipleVersions = true;
 
   static String pubDevUrl = 'https://pub.dev';
   static String pubDartlangUrl = 'https://pub.dartlang.org';
@@ -1818,6 +1816,9 @@ class HostedDescription extends Description {
 
   @override
   HostedSource get source => HostedSource.instance;
+
+  @override
+  bool get hasMultipleVersions => true;
 }
 
 class ResolvedHostedDescription extends ResolvedDescription {

lib/src/source/path.dart

@@ -313,6 +313,9 @@ class PathDescription extends Description {
 
   @override
   int get hashCode => _canonicalizedPath.hashCode;
+
+  @override
+  bool get hasMultipleVersions => false;
 }
 
 class ResolvedPathDescription extends ResolvedDescription {

lib/src/source/root.dart

@@ -119,4 +119,7 @@ class RootDescription extends Description {
 
   @override
   int get hashCode => 'root'.hashCode;
+
+  @override
+  bool get hasMultipleVersions => false;
 }

lib/src/source/sdk.dart

@@ -188,6 +188,9 @@ class SdkDescription extends Description {
   bool operator ==(Object other) {
     return other is SdkDescription && other.sdk == sdk;
   }
+
+  @override
+  bool get hasMultipleVersions => false;
 }
 
 class ResolvedSdkDescription extends ResolvedDescription {

lib/src/source/unknown.dart

@@ -111,6 +111,9 @@ class UnknownDescription extends Description {
 
   @override
   int get hashCode => Object.hash(source.name, json.encode(description));
+
+  @override
+  bool get hasMultipleVersions => false;
 }
 
 class ResolvedUnknownDescription extends ResolvedDescription {