[vm] Remove dead code.

TEST=ci
Change-Id: Ic162deea4a39869a158726616e5c8dc0ff058817
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475781
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

Author: rmacnak-google

runtime/bin/dartutils.cc

@@ -210,22 +210,6 @@ bool DartUtils::IsDartSchemeURL(const char* url_name) {
   return (strncmp(url_name, kDartScheme, kDartSchemeLen) == 0);
 }
 
-bool DartUtils::IsDartIOLibURL(const char* url_name) {
-  return (strcmp(url_name, kIOLibURL) == 0);
-}
-
-bool DartUtils::IsDartCLILibURL(const char* url_name) {
-  return (strcmp(url_name, kCLILibURL) == 0);
-}
-
-bool DartUtils::IsDartHttpLibURL(const char* url_name) {
-  return (strcmp(url_name, kHttpLibURL) == 0);
-}
-
-bool DartUtils::IsDartBuiltinLibURL(const char* url_name) {
-  return (strcmp(url_name, kBuiltinLibURL) == 0);
-}
-
 char* DartUtils::DirName(const char* url) {
   const char* slash = strrchr(url, File::PathSeparator()[0]);
   if (slash == nullptr) {

runtime/bin/dartutils.h

@@ -178,10 +178,6 @@ class DartUtils {
                                     const char* name,
                                     const char* val);
   static bool IsDartSchemeURL(const char* url_name);
-  static bool IsDartIOLibURL(const char* url_name);
-  static bool IsDartCLILibURL(const char* url_name);
-  static bool IsDartHttpLibURL(const char* url_name);
-  static bool IsDartBuiltinLibURL(const char* url_name);
 
   // Returns directory name including the last path separator.
   //

runtime/vm/app_snapshot.cc

@@ -2481,8 +2481,7 @@ class LibraryDeserializationCluster : public DeserializationCluster {
       lib->untag()->index_ = d.Read<int32_t>();
       lib->untag()->num_imports_ = d.Read<uint16_t>();
       lib->untag()->load_state_ = d.Read<int8_t>();
-      lib->untag()->flags_ =
-          UntaggedLibrary::InFullSnapshotBit::update(true, d.Read<uint8_t>());
+      lib->untag()->flags_ = d.Read<uint8_t>();
 #if !defined(DART_PRECOMPILED_RUNTIME)
       ASSERT(d_->kind() != Snapshot::kFullAOT);
       lib->untag()->kernel_library_index_ = d.Read<uint32_t>();

runtime/vm/class_finalizer.cc

@@ -894,25 +894,6 @@ void ClassFinalizer::PrintClassInformation(const Class& cls) {
   }
 }
 
-#endif  // !defined(DART_PRECOMPILED_RUNTIME)
-
-void ClassFinalizer::ReportError(const Error& error) {
-  Report::LongJump(error);
-  UNREACHABLE();
-}
-
-void ClassFinalizer::ReportError(const char* format, ...) {
-  va_list args;
-  va_start(args, format);
-  const Script& null_script = Script::Handle();
-  Report::MessageV(Report::kError, null_script, TokenPosition::kNoSource,
-                   Report::AtLocation, format, args);
-  va_end(args);
-  UNREACHABLE();
-}
-
-#if !defined(DART_PRECOMPILED_RUNTIME)
-
 void ClassFinalizer::VerifyImplicitFieldOffsets() {
 #ifdef DEBUG
   Thread* thread = Thread::Current();

runtime/vm/class_finalizer.h

@@ -97,9 +97,6 @@ class ClassFinalizer : public AllStatic {
   static void PrintClassInformation(const Class& cls);
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)
 
-  static void ReportError(const Error& error);
-  static void ReportError(const char* format, ...) PRINTF_ATTRIBUTE(1, 2);
-
 #if !defined(DART_PRECOMPILED_RUNTIME)
   // Verify implicit offsets recorded in the VM for direct access to fields of
   // Dart instances (e.g: _TypedListView, _ByteDataView).

runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc

@@ -4418,24 +4418,6 @@ Fragment StreamingFlowGraphBuilder::BuildNullLiteral(TokenPosition* position) {
   return Constant(Instance::ZoneHandle(Z, Instance::null()));
 }
 
-Fragment StreamingFlowGraphBuilder::BuildFutureNullValue(
-    TokenPosition* position) {
-  if (position != nullptr) *position = TokenPosition::kNoSource;
-  const Class& future = Class::Handle(Z, IG->object_store()->future_class());
-  ASSERT(!future.IsNull());
-  const auto& error = future.EnsureIsFinalized(thread());
-  ASSERT(error == Error::null());
-  Function& constructor = Function::ZoneHandle(
-      Z, Resolver::ResolveFunction(Z, future, Symbols::FutureValue()));
-  ASSERT(!constructor.IsNull());
-
-  Fragment instructions;
-  instructions += BuildNullLiteral(position);
-  instructions += StaticCall(TokenPosition::kNoSource, constructor,
-                             /* argument_count = */ 1, ICData::kStatic);
-  return instructions;
-}
-
 Fragment StreamingFlowGraphBuilder::BuildConstantExpression(
     TokenPosition* position,
     Tag tag) {

runtime/vm/compiler/frontend/kernel_binary_flowgraph.h

@@ -340,7 +340,6 @@ class StreamingFlowGraphBuilder : public KernelReaderHelper {
   Fragment BuildDoubleLiteral(TokenPosition* position);
   Fragment BuildBoolLiteral(bool value, TokenPosition* position);
   Fragment BuildNullLiteral(TokenPosition* position);
-  Fragment BuildFutureNullValue(TokenPosition* position);
   Fragment BuildConstantExpression(TokenPosition* position, Tag tag);
   Fragment BuildPartialTearoffInstantiation(TokenPosition* position);
   Fragment BuildLibraryPrefixAction(TokenPosition* position,

runtime/vm/compiler/frontend/kernel_fingerprints.cc

@@ -39,7 +39,6 @@ class KernelFingerprintHelper : public KernelReaderHelper {
   void CalculateListOfDartTypesFingerprint();
   void CalculateListOfVariableDeclarationsFingerprint();
   void CalculateStringReferenceFingerprint();
-  void CalculateListOfStringsFingerprint();
   void CalculateTypeParameterFingerprint();
   void CalculateTypeParametersListFingerprint();
   void CalculateCanonicalNameFingerprint();
@@ -138,13 +137,6 @@ void KernelFingerprintHelper::CalculateStringReferenceFingerprint() {
       H.DartString(ReadStringReference()).Hash());  // read ith string index.
 }
 
-void KernelFingerprintHelper::CalculateListOfStringsFingerprint() {
-  intptr_t list_length = ReadListLength();  // read list length.
-  for (intptr_t i = 0; i < list_length; ++i) {
-    CalculateStringReferenceFingerprint();  // read ith string index.
-  }
-}
-
 void KernelFingerprintHelper::CalculateListOfVariableDeclarationsFingerprint() {
   intptr_t list_length = ReadListLength();  // read list length.
   for (intptr_t i = 0; i < list_length; ++i) {

runtime/vm/compiler/relocation_test.cc

@@ -43,7 +43,7 @@ struct RelocatorTestHelper {
   explicit RelocatorTestHelper(Thread* thread)
       : thread(thread),
         locker(thread, thread->isolate_group()->program_lock()),
-        safepoint_and_growth_scope(thread, SafepointLevel::kGC) {
+        safepoint_scope(thread) {
     // So the relocator uses the correct instruction size layout.
     FLAG_precompiled_mode = true;
 
@@ -272,7 +272,7 @@ struct RelocatorTestHelper {
 
   Thread* thread;
   SafepointWriteRwLocker locker;
-  ForceGrowthSafepointOperationScope safepoint_and_growth_scope;
+  GcSafepointOperationScope safepoint_scope;
   GrowableArray<const Code*> codes;
 };
 

runtime/vm/dart.cc

@@ -64,7 +64,6 @@ DEFINE_FLAG(bool, trace_shutdown, false, "Trace VM shutdown on stderr");
 Isolate* Dart::vm_isolate_ = nullptr;
 int64_t Dart::start_time_micros_ = 0;
 ThreadPool* Dart::thread_pool_ = nullptr;
-DebugInfo* Dart::pprof_symbol_generator_ = nullptr;
 ReadOnlyHandles* Dart::predefined_handles_ = nullptr;
 Snapshot::Kind Dart::vm_snapshot_kind_ = Snapshot::kInvalid;
 Dart_ThreadStartCallback Dart::thread_start_callback_ = nullptr;