[kernel] Format kernel

Kernel sdk version was bumped from 3.6 to 3.12 in
https://dart-review.googlesource.com/c/sdk/+/487542 (and to `^3.12.0-0`
in https://dart-review.googlesource.com/c/sdk/+/487880) but the source
was never formatted.

This is, if nothing else, bad for reviews, where editing a file changes
the file in lots of places because of new formatting.

This CL is the result of running

```
out/ReleaseX64/dart-sdk/bin/dart format pkg/kernel/
```

but also updates the formatter version used by a source generator
(`pkg/front_end/tool/visitor_generator.dart`) so things agree.

Change-Id: I66e35d4f1e2d08cecc30fb314546cae78b49e99b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490082
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

Author: jensjoha

pkg/front_end/tool/visitor_generator.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:dart_style/dart_style.dart' show DartFormatter;
+import 'package:pub_semver/pub_semver.dart' as semver;
 
 import 'ast_model.dart';
 
@@ -75,7 +76,7 @@ String generateVisitor(
   String result = sb.toString();
   if (format) {
     result = new DartFormatter(
-      languageVersion: DartFormatter.latestShortStyleLanguageVersion,
+      languageVersion: semver.Version(3, 12, 0),
     ).format(result);
   }
   return result;

pkg/kernel/bin/compare_hierarchies.dart

@@ -13,8 +13,10 @@ import 'package:kernel/src/tool/command_line_util.dart';
 void usage() {
   print("Compares the hierarchies of two dill files.");
   print("");
-  print("Usage: dart <script> dillFile1.dill dillFile2.dill "
-      "[import:uri#classToIgnore|another:uri#andClassToIgnore]");
+  print(
+    "Usage: dart <script> dillFile1.dill dillFile2.dill "
+    "[import:uri#classToIgnore|another:uri#andClassToIgnore]",
+  );
   exit(1);
 }
 
@@ -30,8 +32,10 @@ void main(List<String> args) {
     for (String ignore in ignores) {
       List<String> uriClassName = ignore.split("#");
       if (uriClassName.length != 2) {
-        print("Ignoring '$ignore' as it doesn't conform to "
-            "'importUri#className'");
+        print(
+          "Ignoring '$ignore' as it doesn't conform to "
+          "'importUri#className'",
+        );
         continue;
       }
       Uri uri = Uri.parse(uriClassName[0]);
@@ -59,10 +63,14 @@ void main(List<String> args) {
   for (Uri uri in agreeingImportUris) {
     Library lib1 = libMap1[uri]!;
     Library lib2 = libMap2[uri]!;
-    Map<String, Class> libClass1 =
-        createPublicClassMap(lib1, ignored: ignoresMap[uri]);
-    Map<String, Class> libClass2 =
-        createPublicClassMap(lib2, ignored: ignoresMap[uri]);
+    Map<String, Class> libClass1 = createPublicClassMap(
+      lib1,
+      ignored: ignoresMap[uri],
+    );
+    Map<String, Class> libClass2 = createPublicClassMap(
+      lib2,
+      ignored: ignoresMap[uri],
+    );
     Set<String> agreeingClasses = new Set<String>.from(libClass1.keys)
       ..retainAll(libClass2.keys);
     if (agreeingClasses.length != libClass1.length ||
@@ -84,24 +92,30 @@ void main(List<String> args) {
       Class c1 = libClass1[className]!;
       Class c2 = libClass2[className]!;
       Set<ClassReference> c1Supertypes = createClassReferenceSet(
-          ch1.getAllSupertypeClassesForTesting(c1),
-          onlyPublic: true,
-          ignoresMap: ignoresMap);
+        ch1.getAllSupertypeClassesForTesting(c1),
+        onlyPublic: true,
+        ignoresMap: ignoresMap,
+      );
       Set<ClassReference> c2Supertypes = createClassReferenceSet(
-          ch2.getAllSupertypeClassesForTesting(c2),
-          onlyPublic: true,
-          ignoresMap: ignoresMap);
+        ch2.getAllSupertypeClassesForTesting(c2),
+        onlyPublic: true,
+        ignoresMap: ignoresMap,
+      );
       Set<ClassReference> missing = new Set<ClassReference>.from(c1Supertypes)
         ..removeAll(c2Supertypes);
       if (missing.isNotEmpty) {
-        print("$c1 in $lib1 from (1) has these extra supertypes: "
-            "${missing.toList()}");
+        print(
+          "$c1 in $lib1 from (1) has these extra supertypes: "
+          "${missing.toList()}",
+        );
       }
       missing = new Set<ClassReference>.from(c2Supertypes)
         ..removeAll(c1Supertypes);
       if (missing.isNotEmpty) {
-        print("$c2 in $lib2 from (2) has these extra supertypes: "
-            "${missing.toList()}");
+        print(
+          "$c2 in $lib2 from (2) has these extra supertypes: "
+          "${missing.toList()}",
+        );
       }
     }
   }
@@ -115,8 +129,10 @@ Map<Uri, Library> createLibMap(Component c) {
   return map;
 }
 
-Map<String, Class> createPublicClassMap(Library lib,
-    {required Set<String>? ignored}) {
+Map<String, Class> createPublicClassMap(
+  Library lib, {
+  required Set<String>? ignored,
+}) {
   Map<String, Class> map = {};
   for (Class c in lib.classes) {
     if (c.name.startsWith("_")) continue;
@@ -126,8 +142,11 @@ Map<String, Class> createPublicClassMap(Library lib,
   return map;
 }
 
-Set<ClassReference> createClassReferenceSet(List<Class> classes,
-    {required bool onlyPublic, required Map<Uri, Set<String>> ignoresMap}) {
+Set<ClassReference> createClassReferenceSet(
+  List<Class> classes, {
+  required bool onlyPublic,
+  required Map<Uri, Set<String>> ignoresMap,
+}) {
   Set<ClassReference> result = {};
   for (Class c in classes) {
     if (onlyPublic && c.name.startsWith("_")) continue;

pkg/kernel/bin/count_breakdown.dart

@@ -18,8 +18,11 @@ void usage() {
 }
 
 void main(List<String> args) {
-  CommandLineHelper.requireExactlyOneArgument(args, usage,
-      requireFileExists: true);
+  CommandLineHelper.requireExactlyOneArgument(
+    args,
+    usage,
+    requireFileExists: true,
+  );
   Component component = CommandLineHelper.tryLoadDill(args[0]);
   TypeCounter counter = new TypeCounter();
   component.accept(counter);

pkg/kernel/bin/dill_extractor.dart

@@ -24,7 +24,8 @@ void main(List<String> args) {
     print("Warning: ${args[1]} is an existing dir.");
   } else if (!dir.parent.existsSync()) {
     print(
-        "Warning: ${dir.parent} is not an existing dir, but will be created.");
+      "Warning: ${dir.parent} is not an existing dir, but will be created.",
+    );
     dir.createSync(recursive: true);
   } else {
     dir.createSync();
@@ -47,7 +48,8 @@ void main(List<String> args) {
   Set<MapEntry<Uri, Source>> nonPackageUris = {};
   int writes = 0;
   for (MapEntry<Uri, Source> sourceEntry in component.uriToSource.entries) {
-    Uri uri = sourceEntry.value.importUri ??
+    Uri uri =
+        sourceEntry.value.importUri ??
         sourceEntry.value.fileUri ??
         sourceEntry.key;
     Uri fileUri = sourceEntry.key;
@@ -138,7 +140,7 @@ void main(List<String> args) {
       "name": package.key,
       "rootUri": "../${package.key}",
       "packageUri": "lib/",
-      "languageVersion": version.toText()
+      "languageVersion": version.toText(),
     });
   }
   File.fromUri(dir.uri.resolve(".dart_tool/package_config.json"))

pkg/kernel/bin/dill_forensic.dart

@@ -58,14 +58,17 @@ List<Component> splitAndRead(Uint8List bytes) {
         bytes[index + 2] == magicTagBytes[2] &&
         bytes[index + 3] == magicTagBytes[3]) {
       // Try to read binary version too and see if it matches.
-      int version = (bytes[index + 4] << 24) |
+      int version =
+          (bytes[index + 4] << 24) |
           (bytes[index + 5] << 16) |
           (bytes[index + 6] << 8) |
           bytes[index + 7];
       if (version != Tag.BinaryFormatVersion) {
-        print("Found tag, but version mismatches "
-            "('$version' vs readable version '${Tag.BinaryFormatVersion}'). "
-            "Try again in a different checkout.");
+        print(
+          "Found tag, but version mismatches "
+          "('$version' vs readable version '${Tag.BinaryFormatVersion}'). "
+          "Try again in a different checkout.",
+        );
       } else {
         tagOffsets.add(index);
       }
@@ -86,16 +89,21 @@ List<Component> splitAndRead(Uint8List bytes) {
       // Cut bytes and try to load.
       int fromOffset = tagOffsets[fromIndex];
       int toOffset = tagOffsets[toIndex];
-      Uint8List bytesView =
-          new Uint8List.sublistView(bytes, fromOffset, toOffset);
+      Uint8List bytesView = new Uint8List.sublistView(
+        bytes,
+        fromOffset,
+        toOffset,
+      );
       try {
         Component loaded = loadComponentFromBytes(bytesView);
         components.add(loaded);
         print("Loaded from tag ${fromIndex} to ${toIndex}.");
         break;
       } catch (e) {
-        print("Failed loading from tag ${fromIndex} to ${toIndex}"
-            " (${toOffset - fromOffset} bytes).");
+        print(
+          "Failed loading from tag ${fromIndex} to ${toIndex}"
+          " (${toOffset - fromOffset} bytes).",
+        );
         toIndex++;
       }
     }

pkg/kernel/bin/size_breakdown.dart

@@ -20,8 +20,11 @@ void usage() {
 }
 
 void main(args) {
-  CommandLineHelper.requireExactlyOneArgument(args, usage,
-      requireFileExists: true);
+  CommandLineHelper.requireExactlyOneArgument(
+    args,
+    usage,
+    requireFileExists: true,
+  );
   List<int> bytes = new File(args[0]).readAsBytesSync();
   try {
     Component p = new Component();

pkg/kernel/bin/split.dart

@@ -21,8 +21,11 @@ void usage() {
 }
 
 void main(args) async {
-  CommandLineHelper.requireExactlyOneArgument(args, usage,
-      requireFileExists: true);
+  CommandLineHelper.requireExactlyOneArgument(
+    args,
+    usage,
+    requireFileExists: true,
+  );
   Component binary = CommandLineHelper.tryLoadDill(args[0]);
 
   int part = 1;
@@ -40,12 +43,17 @@ void main(args) async {
 }
 
 Future<Null> writeComponentToFile(
-    Component component, String path, Library wantedLibrary) async {
+  Component component,
+  String path,
+  Library wantedLibrary,
+) async {
   File output = new File(path);
   IOSink sink = output.openWrite();
   try {
-    BinaryPrinter printer =
-        new BinaryPrinter(sink, libraryFilter: (lib) => lib == wantedLibrary);
+    BinaryPrinter printer = new BinaryPrinter(
+      sink,
+      libraryFilter: (lib) => lib == wantedLibrary,
+    );
     printer.writeComponentFile(component);
   } finally {
     await sink.close();

pkg/kernel/bin/switch_order.dart

@@ -23,8 +23,9 @@ void main(List<String> args) {
     List<int> bytes = new File(arg).readAsBytesSync();
     try {
       Component p = new Component();
-      WrappedBinaryBuilder wrappedBinaryBuilder =
-          new WrappedBinaryBuilder(bytes)..readComponent(p);
+      WrappedBinaryBuilder wrappedBinaryBuilder = new WrappedBinaryBuilder(
+        bytes,
+      )..readComponent(p);
       expressionAverages.add(average(wrappedBinaryBuilder.expressionTypes));
       initializerAverages.add(average(wrappedBinaryBuilder.initializerTypes));
       statementAverages.add(average(wrappedBinaryBuilder.statementTypes));
@@ -35,9 +36,11 @@ void main(List<String> args) {
       sumInto(sum, wrappedBinaryBuilder.statementTypes);
       sumInto(sum, wrappedBinaryBuilder.typeTypes);
     } catch (e) {
-      print("Error when reading '$arg'. Dill file expected.\n"
-          "Got error: '$e'.\n\n"
-          "Skipping.");
+      print(
+        "Error when reading '$arg'. Dill file expected.\n"
+        "Got error: '$e'.\n\n"
+        "Skipping.",
+      );
       continue;
     }
   }
@@ -52,7 +55,10 @@ void main(List<String> args) {
 }
 
 void printSummary(
-    String headline, List<List<double>> data, List<int> totalRead) {
+  String headline,
+  List<List<double>> data,
+  List<int> totalRead,
+) {
   if (data.isEmpty) {
     print("$headline: No data.");
     return;
@@ -82,18 +88,24 @@ void printSummary(
     String? tagName = getNameOfTag(i);
     String tagNameExtra = tagName == null ? "" : " ($tagName) ";
     if (minPercentages[i] != maxPercentages[i]) {
-      printMe.add(new SortableDataString(
+      printMe.add(
+        new SortableDataString(
           average,
           "$i$tagNameExtra: ${formatPercent(average)} ("
           "${formatPercent(minPercentages[i])} - "
           "${formatPercent(maxPercentages[i])}) ("
-          "${totalRead[i]} totally recorded)."));
+          "${totalRead[i]} totally recorded).",
+        ),
+      );
     } else {
-      printMe.add(new SortableDataString(
+      printMe.add(
+        new SortableDataString(
           average,
           "$i$tagNameExtra: "
           "${formatPercent(average)} ("
-          "${totalRead[i]} totally recorded)."));
+          "${totalRead[i]} totally recorded).",
+        ),
+      );
     }
   }
   printMe.sort();
@@ -146,10 +158,12 @@ class WrappedBinaryBuilder extends BinaryBuilder {
   List<int> typeTypes = List<int>.filled(255, 0);
 
   WrappedBinaryBuilder(var _bytes)
-      : super(_bytes,
-            disableLazyReading: true,
-            disableLazyClassReading: true,
-            useGrowableLists: false);
+    : super(
+        _bytes,
+        disableLazyReading: true,
+        disableLazyClassReading: true,
+        useGrowableLists: false,
+      );
 
   @override
   Expression readExpression() {

pkg/kernel/bin/type_check.dart

@@ -19,8 +19,11 @@ void usage() {
 }
 
 void main(List<String> args) {
-  CommandLineHelper.requireExactlyOneArgument(args, usage,
-      requireFileExists: true);
+  CommandLineHelper.requireExactlyOneArgument(
+    args,
+    usage,
+    requireFileExists: true,
+  );
   final binary = CommandLineHelper.tryLoadDill(args[0]);
   ErrorFormatter errorFormatter = new ErrorFormatter();
   new NaiveTypeChecker(errorFormatter, binary)..checkComponent(binary);