[analysis_server] Add document links for plugins in analysis_options.yaml

Closes #62493

GitOrigin-RevId: 6fc5b1b
Change-Id: I147c5b4843d1e3437b9212ce6e66ca7285229621
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475422
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Author: bogdanenedoghitoiu

pkg/analysis_server/lib/src/lsp/handlers/handler_document_link.dart

@@ -77,7 +77,7 @@ class DocumentLinkHandler
       return _convert(link, lineInfo);
     }
 
-    var visitor = AnalysisOptionLinkComputer();
+    var visitor = AnalysisOptionLinkComputer(server.pubApi.pubHostedUrl);
     return success(
       visitor.findLinks(analysisOptionsContent).map(convert).toList(),
     );

pkg/analysis_server/test/lsp/document_link_test.dart

@@ -79,6 +79,60 @@ linter:
     await _test_pubspec_links(content, []);
   }
 
+  Future<void> test_analysisOptions_plugins_and_lints() async {
+    var content = '''
+analyzer:
+  plugins:
+    - /*[0*/my_plugin/*0]*/
+
+linter:
+  rules:
+    - /*[1*/await_only_futures/*1]*/
+''';
+
+    var expectedLinks = [
+      '${_pubBase}my_plugin',
+      '${_lintBase}await_only_futures',
+    ];
+
+    await _test_analysisOptions_links(content, expectedLinks);
+  }
+
+  Future<void> test_analysisOptions_plugins_list() async {
+    var content = '''
+analyzer:
+  plugins:
+    - /*[0*/dart_code_metrics/*0]*/
+    - /*[1*/custom_lint/*1]*/
+''';
+
+    var expectedLinks = [
+      '${_pubBase}dart_code_metrics',
+      '${_pubBase}custom_lint',
+    ];
+
+    await _test_analysisOptions_links(content, expectedLinks);
+  }
+
+  Future<void> test_analysisOptions_plugins_map() async {
+    var content = '''
+analyzer:
+  plugins:
+    /*[0*/dart_code_metrics/*0]*/:
+      enabled: true
+    /*[1*/custom_lint/*1]*/:
+      options:
+        foo: bar
+''';
+
+    var expectedLinks = [
+      '${_pubBase}dart_code_metrics',
+      '${_pubBase}custom_lint',
+    ];
+
+    await _test_analysisOptions_links(content, expectedLinks);
+  }
+
   Future<void> test_analysisOptions_undefinedLint() async {
     var content = '''
 linter:

pkg/analyzer_plugin/lib/src/utilities/navigation/document_links.dart

@@ -14,8 +14,9 @@ import 'package:yaml/yaml.dart';
 /// Computes [DocumentLink]s for lint names in an 'analysis_options.yaml'.
 class AnalysisOptionLinkComputer {
   static const _lintsUrl = 'https://dart.dev/tools/linter-rules/';
+  final String pubHostedUrl;
 
-  AnalysisOptionLinkComputer();
+  AnalysisOptionLinkComputer(this.pubHostedUrl);
 
   List<DocumentLink> findLinks(String content) {
     YamlNode node;
@@ -30,7 +31,7 @@ class AnalysisOptionLinkComputer {
     var allRules = <YamlNode>[
       if (node.nodes['linter'] case YamlMap dependencies)
         ...switch (dependencies.nodes['rules']) {
-          YamlMap(:var nodes) => nodes.keys.map((node) => node as YamlNode),
+          YamlMap(:var nodes) => nodes.keys.cast<YamlNode>(),
           YamlList rules => rules.nodes,
           _ => const <YamlNode>[],
         },
@@ -47,6 +48,28 @@ class AnalysisOptionLinkComputer {
       }
     }
 
+    var allPlugins = <YamlNode>[
+      if (node.nodes['analyzer'] case YamlMap analyzer)
+        if (analyzer.nodes['plugins'] case YamlNode plugins)
+          ...switch (plugins) {
+            YamlMap(:var nodes) => nodes.keys.cast<YamlNode>(),
+            YamlList plugins => plugins.nodes,
+            _ => const <YamlNode>[],
+          },
+    ];
+
+    for (final plugin in allPlugins) {
+      var pluginLink = _computePluginLink(plugin);
+
+      if (pluginLink != null) {
+        var offset = plugin.span.start.offset;
+        var length = plugin.span.length;
+        links.add(DocumentLink(offset, length, pluginLink));
+      }
+    }
+
+    links.sort((a, b) => a.offset.compareTo(b.offset));
+
     return links;
   }
 
@@ -65,6 +88,17 @@ class AnalysisOptionLinkComputer {
 
     return Uri.tryParse(_lintsUrl + name);
   }
+
+  /// Computes a link for the plugin named [plugin].
+  Uri? _computePluginLink(YamlNode plugin) {
+    if (plugin is! YamlScalar) return null;
+    var name = plugin.value;
+    if (name is! String || name.isEmpty) return null;
+
+    var separator = pubHostedUrl.endsWith('/') ? '' : '/';
+
+    return Uri.parse('$pubHostedUrl${separator}packages/$name');
+  }
 }
 
 /// A visitor to locate links to other documents in a file.