analyzer: test various annotations with a declaring parameter

Work towards #62254

Change-Id: I697fe2fdf33c4c4bc5ae8c43e57673d86351f787
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475423
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>

Author: srawlins

pkg/analyzer/test/src/diagnostics/invalid_use_of_protected_member_test.dart

@@ -173,19 +173,37 @@ class B extends A {
 import 'package:meta/meta.dart';
 class A {
   @protected
-  int a = 0;
+  int f = 0;
+}
+''');
+    var lib2 = newFile('$testPackageLibPath/lib2.dart', r'''
+import 'lib1.dart';
+abstract class B {
+  int m(A a) => a.f;
 }
+''');
+
+    await assertErrorsInFile2(lib1, []);
+    await assertErrorsInFile2(lib2, [
+      error(diag.invalidUseOfProtectedMember, 57, 1),
+    ]);
+  }
+
+  test_field_outsideClassAndLibrary_originPrimaryConstructor() async {
+    var lib1 = newFile('$testPackageLibPath/lib1.dart', r'''
+import 'package:meta/meta.dart';
+class A(@protected var int f);
 ''');
     var lib2 = newFile('$testPackageLibPath/lib2.dart', r'''
 import 'lib1.dart';
 abstract class B {
-  int b() => new A().a;
+  int m(A a) => a.f;
 }
 ''');
 
     await assertErrorsInFile2(lib1, []);
     await assertErrorsInFile2(lib2, [
-      error(diag.invalidUseOfProtectedMember, 60, 1),
+      error(diag.invalidUseOfProtectedMember, 57, 1),
     ]);
   }
 

pkg/analyzer/test/src/diagnostics/invalid_use_of_visible_for_overriding_member_test.dart

@@ -89,6 +89,47 @@ class Child extends Parent {
 ''');
   }
 
+  test_field() async {
+    newFile('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A {
+  @visibleForOverriding
+  int g = 0;
+}
+''');
+
+    await assertErrorsInCode(
+      '''
+import 'a.dart';
+
+int m(A a) {
+  return a.g;
+}
+''',
+      [error(diag.invalidUseOfVisibleForOverridingMember, 42, 1)],
+    );
+  }
+
+  test_field_originPrimaryConstructor() async {
+    newFile('$testPackageLibPath/a.dart', '''
+import 'package:meta/meta.dart';
+
+class A(@visibleForOverriding var int g);
+''');
+
+    await assertErrorsInCode(
+      '''
+import 'a.dart';
+
+int m(A a) {
+  return a.g;
+}
+''',
+      [error(diag.invalidUseOfVisibleForOverridingMember, 42, 1)],
+    );
+  }
+
   test_getter() async {
     newFile('$testPackageLibPath/a.dart', '''
 import 'package:meta/meta.dart';

pkg/analyzer/test/src/diagnostics/unused_result_test.dart

@@ -456,6 +456,21 @@ void main() {
     );
   }
 
+  test_field_result_unassigned_originPrimaryConstructor() async {
+    await assertErrorsInCode(
+      r'''
+import 'package:meta/meta.dart';
+
+class A(@useResult var int foo);
+
+void f(A a) {
+  a.foo;
+}
+''',
+      [error(diag.unusedResult, 86, 3)],
+    );
+  }
+
   test_field_result_used_conditional_if_parens() async {
     await assertNoErrorsInCode(r'''
 import 'package:meta/meta.dart';