Skip to content

Commit 7c60da7

Browse files
srawlinsCommit Queue
authored andcommitted
analyzer: Test that @awaitNotRequired on a declaring parameter works
Work towards #62254 Change-Id: Ic00093370d85a3ab2f0dd0101fafb087c987c6f9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/475401 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
1 parent 3d63e3a commit 7c60da7

2 files changed

Lines changed: 17 additions & 0 deletions

File tree

pkg/analyzer/test/src/diagnostics/invalid_await_not_required_annotation_test.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,13 @@ class C {
119119
''');
120120
}
121121

122+
test_valid_field_futureReturnType_originPrimaryConstructor() async {
123+
await assertNoErrorsInCode('''
124+
import 'package:meta/meta.dart';
125+
class C(@awaitNotRequired final Future<int> x);
126+
''');
127+
}
128+
122129
test_valid_function_futureOrReturnType() async {
123130
await assertNoErrorsInCode('''
124131
import 'dart:async';

pkg/linter/test/rules/unawaited_futures_test.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,16 @@ abstract class C {
288288
''');
289289
}
290290

291+
test_instanceProperty_unawaited_awaitNotRequired_originPrimaryConstructor() async {
292+
await assertNoDiagnostics(r'''
293+
import 'package:meta/meta.dart';
294+
void f(C c) async {
295+
c.p;
296+
}
297+
abstract class C(@awaitNotRequired final Future<int> p);
298+
''');
299+
}
300+
291301
test_instanceProperty_unawaited_awaitNotRequiredInherited() async {
292302
await assertNoDiagnostics(r'''
293303
import 'package:meta/meta.dart';

0 commit comments

Comments
 (0)