Augment. Enable a few hierarchy tests, add more.

Change-Id: I24df92334408ee04f4fe638200561c63b4fd4ce7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507266
Reviewed-by: Paul Berry <paulberry@google.com>

Author: scheglov

pkg/analyzer/test/src/diagnostics/augmentation_extends_clause_already_present_test.dart

@@ -44,6 +44,56 @@ augment class B extends A {}
 ''');
   }
 
+  test_alreadyPresent2_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class A {}
+
+class B extends A {}
+//    ^
+// [context 1] The declaration being augmented.
+
+augment class B {}
+''',
+      b: r'''
+part of 'a.dart';
+
+augment class B extends A {}
+//              ^^^^^^^
+// [diag.augmentationExtendsClauseAlreadyPresent][context 1] The augmentation has an 'extends' clause, but an augmentation target already includes an 'extends' clause and it isn't allowed to be repeated or changed.
+''',
+    });
+  }
+
+  test_alreadyPresent_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class A {}
+
+class B extends A {}
+//    ^
+// [context 1] The declaration being augmented.
+''',
+      b: r'''
+part of 'a.dart';
+
+augment class B extends A {}
+//              ^^^^^^^
+// [diag.augmentationExtendsClauseAlreadyPresent][context 1] The augmentation has an 'extends' clause, but an augmentation target already includes an 'extends' clause and it isn't allowed to be repeated or changed.
+''',
+    });
+  }
+
   test_notPresent() async {
     await resolveTestCodeWithDiagnostics(r'''
 class A {}

pkg/analyzer/test/src/diagnostics/conflicting_generic_interfaces_test.dart

@@ -16,16 +16,39 @@ main() {
 
 @reflectiveTest
 class ConflictingGenericInterfacesTest extends PubPackageResolutionTest {
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_class_extends_augmentation_implements() async {
     await resolveTestCodeWithDiagnostics('''
 class I<T> {}
 class A implements I<int> {}
 class B extends A {}
+//    ^
+// [diag.conflictingGenericInterfaces] The class 'B' can't implement both 'I<int>' and 'I<String>' because the type arguments are different.
 augment class B implements I<String> {}
 ''');
   }
 
+  test_class_extends_augmentation_implements_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class I<T> {}
+class A implements I<int> {}
+class B extends A {}
+//    ^
+// [diag.conflictingGenericInterfaces] The class 'B' can't implement both 'I<int>' and 'I<String>' because the type arguments are different.
+''',
+      b: r'''
+part of 'a.dart';
+
+augment class B implements I<String> {}
+''',
+    });
+  }
+
   test_class_extends_implements() async {
     await resolveTestCodeWithDiagnostics('''
 class I<T> {}

pkg/analyzer/test/src/diagnostics/implements_repeated_test.dart

@@ -40,15 +40,37 @@ ImplementsClause
 ''');
   }
 
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_class_implements_2times_augmentation() async {
     await resolveTestCodeWithDiagnostics(r'''
 class A {}
 class B implements A {}
 augment class B implements A {}
+//                         ^
+// [diag.implementsRepeated] 'A' can only be implemented once.
 ''');
   }
 
+  test_class_implements_2times_augmentation_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class A {}
+class B implements A {}
+''',
+      b: r'''
+part of 'a.dart';
+
+augment class B implements A {}
+//                         ^
+// [diag.implementsRepeated] 'A' can only be implemented once.
+''',
+    });
+  }
+
   test_class_implements_2times_viaTypeAlias() async {
     var result = await resolveTestCodeWithDiagnostics(r'''
 class A {}
@@ -114,15 +136,37 @@ ImplementsClause
 ''');
   }
 
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_enum_implements_2times_augmentation() async {
     await resolveTestCodeWithDiagnostics(r'''
 class A {}
 enum E implements A {v}
 augment enum E implements A {}
+//                        ^
+// [diag.implementsRepeated] 'A' can only be implemented once.
 ''');
   }
 
+  test_enum_implements_2times_augmentation_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class A {}
+enum E implements A {v}
+''',
+      b: r'''
+part of 'a.dart';
+
+augment enum E implements A {}
+//                        ^
+// [diag.implementsRepeated] 'A' can only be implemented once.
+''',
+    });
+  }
+
   test_enum_implements_2times_viaTypeAlias() async {
     var result = await resolveTestCodeWithDiagnostics(r'''
 class A {}
@@ -189,14 +233,35 @@ ImplementsClause
 ''');
   }
 
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_extensionType_implements_2times_augmentation() async {
     await resolveTestCodeWithDiagnostics(r'''
 extension type A(int it) implements int {}
 augment extension type A implements int {}
+//                                  ^^^
+// [diag.implementsRepeated] 'int' can only be implemented once.
 ''');
   }
 
+  test_extensionType_implements_2times_augmentation_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+extension type A(int it) implements int {}
+''',
+      b: r'''
+part of 'a.dart';
+
+augment extension type A implements int {}
+//                                  ^^^
+// [diag.implementsRepeated] 'int' can only be implemented once.
+''',
+    });
+  }
+
   test_extensionType_implements_2times_viaTypeAlias() async {
     var result = await resolveTestCodeWithDiagnostics(r'''
 typedef A = int;
@@ -243,15 +308,37 @@ mixin M implements A, A {}
 ''');
   }
 
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_mixin_implements_2times_augmentation() async {
     await resolveTestCodeWithDiagnostics(r'''
 class A {}
 mixin M implements A {}
 augment mixin M implements A {}
+//                         ^
+// [diag.implementsRepeated] 'A' can only be implemented once.
 ''');
   }
 
+  test_mixin_implements_2times_augmentation_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class A {}
+mixin M implements A {}
+''',
+      b: r'''
+part of 'a.dart';
+
+augment mixin M implements A {}
+//                         ^
+// [diag.implementsRepeated] 'A' can only be implemented once.
+''',
+    });
+  }
+
   test_mixin_implements_4times() async {
     await resolveTestCodeWithDiagnostics(r'''
 class A {}

pkg/analyzer/test/src/diagnostics/implements_super_class_test.dart

@@ -23,6 +23,68 @@ class B extends A implements A {}
 ''');
   }
 
+  test_class_extendsThenAugmentsImplements() async {
+    await resolveTestCodeWithDiagnostics(r'''
+class A {}
+class B extends A {}
+augment class B implements A {}
+//                         ^
+// [diag.implementsSuperClass] 'class A' can't be used in both the 'extends' and 'implements' clauses.
+''');
+  }
+
+  test_class_extendsThenAugmentsImplements_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class A {}
+class B extends A {}
+''',
+      b: r'''
+part of 'a.dart';
+
+augment class B implements A {}
+//                         ^
+// [diag.implementsSuperClass] 'class A' can't be used in both the 'extends' and 'implements' clauses.
+''',
+    });
+  }
+
+  test_class_implementsThenAugmentsExtends() async {
+    await resolveTestCodeWithDiagnostics(r'''
+class A {}
+class B implements A {}
+//                 ^
+// [diag.implementsSuperClass] 'class A' can't be used in both the 'extends' and 'implements' clauses.
+augment class B extends A {}
+''');
+  }
+
+  test_class_implementsThenAugmentsExtends_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class A {}
+class B implements A {}
+//                 ^
+// [diag.implementsSuperClass] 'class A' can't be used in both the 'extends' and 'implements' clauses.
+''',
+      b: r'''
+part of 'a.dart';
+
+augment class B extends A {}
+''',
+    });
+  }
+
   test_class_Object() async {
     await resolveTestCodeWithDiagnostics(r'''
 class A implements Object {}

pkg/analyzer/test/src/diagnostics/mixin_application_not_implemented_interface_test.dart

@@ -63,16 +63,39 @@ class C extends Object with M {}
 ''');
   }
 
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_class_noMatchingInterface_fromAugmentation() async {
     await resolveTestCodeWithDiagnostics('''
 class B with M {}
+//           ^
+// [diag.mixinApplicationNotImplementedInterface] 'M' can't be mixed onto 'Object' because 'Object' doesn't implement 'A'.
 mixin M {}
 class A {}
 augment mixin M on A {}
 ''');
   }
 
+  test_class_noMatchingInterface_fromAugmentation_part() async {
+    var a = getFile('$testPackageLibPath/a.dart');
+    var b = getFile('$testPackageLibPath/b.dart');
+
+    await resolveFilesWithDiagnostics({
+      a: r'''
+part 'b.dart';
+
+class B with M {}
+//           ^
+// [diag.mixinApplicationNotImplementedInterface] 'M' can't be mixed onto 'Object' because 'Object' doesn't implement 'A'.
+mixin M {}
+class A {}
+''',
+      b: r'''
+part of 'a.dart';
+
+augment mixin M on A {}
+''',
+    });
+  }
+
   test_class_noMatchingInterface_withTypeArguments() async {
     await resolveTestCodeWithDiagnostics('''
 abstract class A<T> {}
@@ -280,7 +303,6 @@ enum E with M {
 ''');
   }
 
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_enum_noSuperclassConstraint_augmented() async {
     await resolveTestCodeWithDiagnostics(r'''
 mixin M {}

pkg/analyzer/test/src/diagnostics/mixin_super_class_constraint_disallowed_class_test.dart

@@ -43,11 +43,12 @@ MixinOnClause
 ''');
   }
 
-  @SkippedTest() // TODO(scheglov): implement augmentation
   test_in_inAugmentation() async {
     await resolveTestCodeWithDiagnostics(r'''
 mixin A {}
 augment mixin A on int {}
+//                 ^^^
+// [diag.mixinSuperClassConstraintDisallowedClass] 'int' can't be used as a superclass constraint.
 ''');
   }