Skip to content

Commit e42e886

Browse files
mkustermannCommit Queue
authored andcommitted
[dart2wasm] Ensure --enable-protobuf-mixin-tree-shaker enables --enable-protobuf-tree-shaker
When `--enable-protobuf-mixin-tree-shaker` is enabled then we should also enable `--enable-protobuf-tree-shaker` internally. This mirrors the behavior in dart2js which does this in pkg/compiler/lib/src/options.dart: ``` ..enableProtoShaking = _hasOption(options, Flags.enableProtoShaking) || _hasOption(options, Flags.enableProtoMixinShaking) ``` Change-Id: I72e9e8951ead747bc8dcb9fb134eb8a6369a3eab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490841 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
1 parent 4ee6a66 commit e42e886

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

pkg/dart2wasm/lib/compile.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,9 @@ Future<CompilationResult> _runTfaPhase(
630630
coreTypes,
631631
component,
632632
useRapidTypeAnalysis: true,
633-
treeShakeProtobufs: options.translatorOptions.enableProtobufTreeShaker,
633+
treeShakeProtobufs:
634+
options.translatorOptions.enableProtobufTreeShaker ||
635+
options.translatorOptions.enableProtobufMixinTreeShaker,
634636
treeShakeProtobufMixins:
635637
options.translatorOptions.enableProtobufMixinTreeShaker,
636638
);

0 commit comments

Comments
 (0)