[analysis_server] Exclude NameWithTypeParameters from selection ranges

This makes things more consistent between class/mixin (that have different ASTs) but also avoids jumping to the name+type args which probably isn't what you'd expect.

Change-Id: Ibd5e2a9b332c4c214ccc753080a61b1222445485
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/490260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

Author: DanTup

pkg/analysis_server/lib/src/computer/computer_selection_ranges.dart

@@ -42,6 +42,11 @@ class DartSelectionRangeComputer {
       }
     }
 
+    // Ignore certain kinds of nodes.
+    if (node is NameWithTypeParameters) {
+      return;
+    }
+
     _selectionRanges.add(SelectionRange(node.offset, node.length));
   }
 }

pkg/analysis_server/test/lsp/selection_range_test.dart

@@ -92,7 +92,7 @@ void f() {
 class ^C;
 ''';
 
-    await verifySelectionRanges(content, ['C', 'class C;']);
+    await verifySelectionRanges(content, ['class C;']);
   }
 
   Future<void> test_emptyBody_enum() async {
@@ -102,7 +102,7 @@ class ^C;
 enum ^E;
 ''';
 
-    await verifySelectionRanges(content, ['E', 'enum E;']);
+    await verifySelectionRanges(content, ['enum E;']);
   }
 
   Future<void> test_emptyBody_extension() async {