Commit e43744b
authored
[dwds] Fix ping event serialization by introducing PingRequest (#2821)
**Changes:**
- Replaced the raw map `{'type': 'ping'}` used for client connection checks with a proper `PingRequest` class. This fixes a `TypeError` in the browser client when trying to deserialize the raw map as a list (due to expected wire format mismatch), and aligns the ping event with the ongoing migration to standard JSON serialization in DWDS.
**Tests:**
- Added unit tests to verify the change.
Related to #28061 parent 1063eb0 commit e43744b
9 files changed
Lines changed: 210 additions & 180 deletions
File tree
- dwds
- lib
- data
- src
- handlers
- services/web_socket
- test/integration
- web
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
1 | 5 | | |
2 | 6 | | |
3 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
165 | 166 | | |
166 | 167 | | |
167 | 168 | | |
168 | | - | |
| 169 | + | |
| 170 | + | |
169 | 171 | | |
170 | 172 | | |
171 | 173 | | |
| |||
0 commit comments