Merge pull request mixxxdj#16655 from mixxxdj/yaeltex-shift-fix

Yaeltex Minimixxx: fix shift-pitch behavior

Author: ronso0

res/controllers/Yaeltex MiniMixxx.midi.xml

@@ -7,6 +7,21 @@
     <!-- <wiki></wiki>
     <forums></forums> -->
   </info>
+  <settings>
+    <group label="Controller Behavior">
+        <row orientation="vertical">
+            <option
+                variable="shiftPitch"
+                type="boolean"
+                default="false"
+                label="Only adjust pitch when shift button is held">
+                <description>
+                    When set to true, only allows adjustments to pitch when shift is held. Useful for preventing accidental adjustments.
+                </description>
+            </option>
+        </row>
+    </group>
+  </settings>
   <controller id="MiniMixxx">
     <scriptfiles>
       <file filename="Yaeltex-MiniMixxx-scripts.js" functionprefix="MiniMixxx" />

res/controllers/Yaeltex-MiniMixxx-scripts.js

@@ -31,7 +31,7 @@ MiniMixxx.DebugMode = false;
 
 // Set to true to only allow adjustments to the pitch sliders if Shift is held.
 // This can prevent accidental adjustments.
-MiniMixxx.ShiftPitch = false;
+MiniMixxx.ShiftPitch = engine.getSetting("shiftPitch") || false;
 
 // An Encoder represents a single encoder knob and tracks the active mode.
 MiniMixxx.Encoder = class {
@@ -1457,8 +1457,8 @@ MiniMixxx.Controller = class {
             return;
         }
 
-        // If shift is pressed, don't update any values.
-        if (!this.shiftActive() && !this.keylockPressed(group)) {
+        // Only adjust pitch based on ShiftPitch setting.
+        if ((MiniMixxx.ShiftPitch === !this.shiftActive()) && !this.keylockPressed(group)) {
             this.pitchSliderLastValue[group] = value;
             return;
         }