Skip to content

Commit eb3e168

Browse files
committed
Merge branch '2.6' into 'main'
2 parents 6a834ce + 6d10977 commit eb3e168

5 files changed

Lines changed: 30 additions & 0 deletions

File tree

src/library/library_prefs.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ const ConfigKey mixxx::library::prefs::kRescanOnStartupConfigKey =
1818
mixxx::library::prefs::kConfigGroup,
1919
QStringLiteral("RescanOnStartup")};
2020

21+
const ConfigKey mixxx::library::prefs::kShowScanSummaryConfigKey =
22+
ConfigKey{
23+
mixxx::library::prefs::kConfigGroup,
24+
QStringLiteral("show_library_scan_summary")};
25+
2126
const ConfigKey mixxx::library::prefs::kKeyNotationConfigKey =
2227
ConfigKey{
2328
mixxx::library::prefs::kConfigGroup,

src/library/library_prefs.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ extern const QString kConfigGroup;
1414

1515
extern const ConfigKey kRescanOnStartupConfigKey;
1616

17+
extern const ConfigKey kShowScanSummaryConfigKey;
18+
1719
extern const ConfigKey kKeyNotationConfigKey;
1820

1921
extern const ConfigKey kTrackDoubleClickActionConfigKey;

src/mixxxmainwindow.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
#ifdef __ENGINEPRIME__
4040
#include "library/export/libraryexporter.h"
4141
#endif
42+
#include "library/library_prefs.h"
4243
#include "library/overviewcache.h"
4344
#include "library/trackcollectionmanager.h"
4445
#include "mixer/playerinfo.h"
@@ -1227,6 +1228,11 @@ void MixxxMainWindow::slotHelpAbout() {
12271228
}
12281229

12291230
void MixxxMainWindow::slotLibraryScanSummaryDlg(const LibraryScanResultSummary& result) {
1231+
if (!m_pCoreServices->getSettings()->getValue<bool>(
1232+
mixxx::library::prefs::kShowScanSummaryConfigKey, true)) {
1233+
return;
1234+
}
1235+
12301236
// Don't show the report dialog when the scan is run during startup and no
12311237
// noteworthy changes have been detected.
12321238
if (result.autoscan &&

src/preferences/dialog/dlgpreflibrary.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,8 @@ void DlgPrefLibrary::slotUpdate() {
277277
populateDirList();
278278
checkBox_library_scan->setChecked(m_pConfig->getValue(
279279
kRescanOnStartupConfigKey, false));
280+
checkBox_library_scan_summary->setChecked(m_pConfig->getValue(
281+
kShowScanSummaryConfigKey, true));
280282

281283
spinbox_history_track_duplicate_distance->setValue(m_pConfig->getValue(
282284
kHistoryTrackDuplicateDistanceConfigKey,
@@ -509,6 +511,9 @@ void DlgPrefLibrary::slotApply() {
509511
m_pConfig->set(kRescanOnStartupConfigKey,
510512
ConfigValue((int)checkBox_library_scan->isChecked()));
511513

514+
m_pConfig->set(kShowScanSummaryConfigKey,
515+
ConfigValue((int)checkBox_library_scan_summary->isChecked()));
516+
512517
m_pConfig->set(kHistoryTrackDuplicateDistanceConfigKey,
513518
ConfigValue(spinbox_history_track_duplicate_distance->value()));
514519
m_pConfig->set(kHistoryMinTracksToKeepConfigKey,

src/preferences/dialog/dlgpreflibrarydlg.ui

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,17 @@
8989
</widget>
9090
</item>
9191

92+
<item row="4" column="0" colspan="2">
93+
<widget class="QCheckBox" name="checkBox_library_scan_summary">
94+
<property name="text">
95+
<string>Show scan summary dialog</string>
96+
</property>
97+
<property name="checked">
98+
<bool>true</bool>
99+
</property>
100+
</widget>
101+
</item>
102+
92103
</layout>
93104
</widget>
94105
</item>
@@ -671,6 +682,7 @@
671682
<tabstop>pushButton_relocate_dir</tabstop>
672683
<tabstop>pushButton_remove_dir</tabstop>
673684
<tabstop>checkBox_library_scan</tabstop>
685+
<tabstop>checkBox_library_scan_summary</tabstop>
674686
<tabstop>checkBox_sync_track_metadata</tabstop>
675687
<tabstop>checkBox_serato_metadata_export</tabstop>
676688
<tabstop>checkBox_use_relative_path</tabstop>

0 commit comments

Comments
 (0)