Skip to content

Commit c50a7d1

Browse files
PastaPastaPastaPastaPastaPasta
authored
Merge pull request #5785 from ogabrielides/20.0.3-release
backport: v20.0.3 backports and release
2 parents b1e9e05 + 3192d8c commit c50a7d1

18 files changed

+301
-67
lines changed

‎configure.ac

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
AC_PREREQ([2.69])
22
define(_CLIENT_VERSION_MAJOR, 20)
33
define(_CLIENT_VERSION_MINOR, 0)
4-
define(_CLIENT_VERSION_BUILD, 2)
4+
define(_CLIENT_VERSION_BUILD, 3)
55
define(_CLIENT_VERSION_RC, 0)
66
define(_CLIENT_VERSION_IS_RELEASE, true)
77
define(_COPYRIGHT_YEAR, 2023)

‎doc/release-notes.md

+11-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Dash Core version v20.0.2
1+
# Dash Core version v20.0.3
22

33
Release is now available from:
44

@@ -37,18 +37,22 @@ reindex or re-sync the whole chain.
3737

3838
## Masternode fix
3939

40-
A problem has been fixed in the old quorum data cleanup mechanism. It was slowing down masternodes during DKG sessions and causing them to get PoSe scored.
40+
The memory usage during the old quorum data cleanup mechanism was reduced.
4141

42-
## Testnet Crash
42+
## Wallet fix
4343

44-
A fix has been implemented for the reported crash that could occur when upgrading from v19.x to v20.0.0 after v20 activation without re-indexing.
44+
A fix has been implemented for the reported decryption of wallets.
45+
46+
## RPC changes
47+
48+
In `getspecialtxes` `instantlock` and `chainlock` fields are reflecting actual values now.
4549

4650
## Other changes
4751

4852
Implemented improvements in Github CI and build system for macOS. Fixed compilation issues on FreeBSD.
4953

5054

51-
# v20.0.2 Change log
55+
# v20.0.3 Change log
5256

5357
See detailed [set of changes][set-of-changes].
5458

@@ -86,6 +90,7 @@ Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
8690

8791
These release are considered obsolete. Old release notes can be found here:
8892

93+
- [v20.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.2.md) released December/06/2023
8994
- [v20.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.1.md) released November/18/2023
9095
- [v20.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.0.md) released November/15/2023
9196
- [v19.3.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.3.0.md) released July/31/2023
@@ -130,4 +135,4 @@ These release are considered obsolete. Old release notes can be found here:
130135
- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014
131136
- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014
132137

133-
[set-of-changes]: https://github.com/dashpay/dash/compare/v20.0.1...dashpay:v20.0.2
138+
[set-of-changes]: https://github.com/dashpay/dash/compare/v20.0.2...dashpay:v20.0.3

‎doc/release-notes/dash/release-notes-20.0.2.md

+133
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,133 @@
1+
# Dash Core version v20.0.2
2+
3+
Release is now available from:
4+
5+
<https://www.dash.org/downloads/#wallets>
6+
7+
This is a new patch version release, bringing small bug fixes and build system enhancements.
8+
9+
This release is optional for all nodes.
10+
11+
Please report bugs using the issue tracker at GitHub:
12+
13+
<https://github.com/dashpay/dash/issues>
14+
15+
16+
# Upgrading and downgrading
17+
18+
## How to Upgrade
19+
20+
If you are running an older version, shut it down. Wait until it has completely
21+
shut down (which might take a few minutes for older versions), then run the
22+
installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or
23+
dashd/dash-qt (on Linux). If you upgrade after DIP0003 activation and you were
24+
using version < 0.13 you will have to reindex (start with -reindex-chainstate
25+
or -reindex) to make sure your wallet has all the new data synced. Upgrading
26+
from version 0.13 should not require any additional actions.
27+
28+
## Downgrade warning
29+
30+
### Downgrade to a version < v19.2.0
31+
32+
Downgrading to a version older than v19.2.0 is not supported due to changes
33+
in the evodb database. If you need to use an older version, you must either
34+
reindex or re-sync the whole chain.
35+
36+
# Notable changes
37+
38+
## Masternode fix
39+
40+
A problem has been fixed in the old quorum data cleanup mechanism. It was slowing down masternodes during DKG sessions and causing them to get PoSe scored.
41+
42+
## Testnet Crash
43+
44+
A fix has been implemented for the reported crash that could occur when upgrading from v19.x to v20.0.0 after v20 activation without re-indexing.
45+
46+
## Other changes
47+
48+
Implemented improvements in Github CI and build system for macOS. Fixed compilation issues on FreeBSD.
49+
50+
51+
# v20.0.2 Change log
52+
53+
See detailed [set of changes][set-of-changes].
54+
55+
# Credits
56+
57+
Thanks to everyone who directly contributed to this release:
58+
59+
- Konstantin Akimov (knst)
60+
- Odysseas Gabrielides (ogabrielides)
61+
- PastaPastaPasta
62+
- UdjinM6
63+
64+
As well as everyone that submitted issues, reviewed pull requests and helped
65+
debug the release candidates.
66+
67+
# Older releases
68+
69+
Dash was previously known as Darkcoin.
70+
71+
Darkcoin tree 0.8.x was a fork of Litecoin tree 0.8, original name was XCoin
72+
which was first released on Jan/18/2014.
73+
74+
Darkcoin tree 0.9.x was the open source implementation of masternodes based on
75+
the 0.8.x tree and was first released on Mar/13/2014.
76+
77+
Darkcoin tree 0.10.x used to be the closed source implementation of Darksend
78+
which was released open source on Sep/25/2014.
79+
80+
Dash Core tree 0.11.x was a fork of Bitcoin Core tree 0.9,
81+
Darkcoin was rebranded to Dash.
82+
83+
Dash Core tree 0.12.0.x was a fork of Bitcoin Core tree 0.10.
84+
85+
Dash Core tree 0.12.1.x was a fork of Bitcoin Core tree 0.12.
86+
87+
These release are considered obsolete. Old release notes can be found here:
88+
89+
- [v20.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.1.md) released November/18/2023
90+
- [v20.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.0.md) released November/15/2023
91+
- [v19.3.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.3.0.md) released July/31/2023
92+
- [v19.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.2.0.md) released June/19/2023
93+
- [v19.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.1.0.md) released May/22/2023
94+
- [v19.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.0.0.md) released Apr/14/2023
95+
- [v18.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.2.md) released Mar/21/2023
96+
- [v18.2.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.1.md) released Jan/17/2023
97+
- [v18.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.0.md) released Jan/01/2023
98+
- [v18.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.1.md) released January/08/2023
99+
- [v18.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.0.md) released October/09/2022
100+
- [v18.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.2.md) released October/09/2022
101+
- [v18.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.1.md) released August/17/2022
102+
- [v0.17.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.17.0.3.md) released June/07/2021
103+
- [v0.17.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.17.0.2.md) released May/19/2021
104+
- [v0.16.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.1.md) released November/17/2020
105+
- [v0.16.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.0.md) released November/14/2020
106+
- [v0.16.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.0.1.md) released September/30/2020
107+
- [v0.15.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.15.0.0.md) released Febrary/18/2020
108+
- [v0.14.0.5](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.5.md) released December/08/2019
109+
- [v0.14.0.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.4.md) released November/22/2019
110+
- [v0.14.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.3.md) released August/15/2019
111+
- [v0.14.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.2.md) released July/4/2019
112+
- [v0.14.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.1.md) released May/31/2019
113+
- [v0.14.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.md) released May/22/2019
114+
- [v0.13.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.3.md) released Apr/04/2019
115+
- [v0.13.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.2.md) released Mar/15/2019
116+
- [v0.13.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.1.md) released Feb/9/2019
117+
- [v0.13.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.0.md) released Jan/14/2019
118+
- [v0.12.3.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.4.md) released Dec/14/2018
119+
- [v0.12.3.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.3.md) released Sep/19/2018
120+
- [v0.12.3.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.2.md) released Jul/09/2018
121+
- [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018
122+
- [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018
123+
- [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017
124+
- [v0.12.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.md) released Nov/08/2017
125+
- [v0.12.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.1.md) released Feb/06/2017
126+
- [v0.12.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.0.md) released Aug/15/2015
127+
- [v0.11.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.2.md) released Mar/04/2015
128+
- [v0.11.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.1.md) released Feb/10/2015
129+
- [v0.11.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.0.md) released Jan/15/2015
130+
- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014
131+
- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014
132+
133+
[set-of-changes]: https://github.com/dashpay/dash/compare/v20.0.1...dashpay:v20.0.2

‎src/llmq/dkgsessionmgr.cpp

+1-5
Original file line numberDiff line numberDiff line change
@@ -465,10 +465,6 @@ void CDKGSessionManager::CleanupOldContributions() const
465465
const auto prefixes = {DB_VVEC, DB_SKCONTRIB, DB_ENC_CONTRIB};
466466

467467
for (const auto& params : Params().GetConsensus().llmqs) {
468-
// For how many blocks recent DKG info should be kept
469-
const int MAX_CYCLES = params.useRotation ? params.keepOldKeys / params.signingActiveQuorumCount : params.keepOldKeys;
470-
const int MAX_STORE_DEPTH = MAX_CYCLES * params.dkgInterval;
471-
472468
LogPrint(BCLog::LLMQ, "CDKGSessionManager::%s -- looking for old entries for llmq type %d\n", __func__, ToUnderlying(params.type));
473469

474470
CDBBatch batch(*db);
@@ -486,7 +482,7 @@ void CDKGSessionManager::CleanupOldContributions() const
486482
}
487483
cnt_all++;
488484
const CBlockIndex* pindexQuorum = m_chainstate.m_blockman.LookupBlockIndex(std::get<2>(k));
489-
if (pindexQuorum == nullptr || m_chainstate.m_chain.Tip()->nHeight - pindexQuorum->nHeight > MAX_STORE_DEPTH) {
485+
if (pindexQuorum == nullptr || m_chainstate.m_chain.Tip()->nHeight - pindexQuorum->nHeight > utils::max_store_depth(params)) {
490486
// not found or too old
491487
batch.Erase(k);
492488
cnt_old++;

0 commit comments

Comments
 (0)