fix: intermittent error in wallet_mnemonic.py due to different order of descriptors

Descriptor with Coinbase private key can be in any position

Author: knst

test/functional/wallet_mnemonicbits.py

@@ -17,6 +17,26 @@ def set_test_params(self):
     def skip_test_if_missing_module(self):
         self.skip_if_no_wallet()
 
+    def get_mnemonic(self, node):
+        if not self.options.descriptors:
+            return node.dumphdinfo()["mnemonic"]
+
+        mnemonic = None
+        descriptors = node.listdescriptors(True)['descriptors']
+        for desc in descriptors:
+            if desc['desc'][:4] == 'pkh(':
+                pass
+                if mnemonic is None:
+                    mnemonic = desc['mnemonic']
+                else:
+                    assert_equal(mnemonic, desc['mnemonic'])
+            elif desc['desc'][:6] == 'combo(':
+                assert 'mnemonic' not in desc
+            else:
+                self.log.info(f"unknown type of descriptor: {desc['desc']}")
+                assert False
+        return mnemonic
+
     def run_test(self):
         self.log.info("Test -mnemonicbits")
 
@@ -25,33 +45,32 @@ def run_test(self):
         self.nodes[0].assert_start_raises_init_error(['-mnemonicbits=123'], "Error: Invalid '-mnemonicbits'. Allowed values: 128, 160, 192, 224, 256.")
         self.start_node(0)
 
-        mnemonic_pre = self.nodes[0].listdescriptors(True)['descriptors'][1]["mnemonic"] if self.options.descriptors else self.nodes[0].dumphdinfo()["mnemonic"]
+        mnemonic_pre = self.get_mnemonic(self.nodes[0])
+
 
         self.nodes[0].encryptwallet('pass')
         self.nodes[0].walletpassphrase('pass', 100)
         if self.options.descriptors:
-            assert "mnemonic" not in self.nodes[0].listdescriptors()['descriptors'][0]
-            assert "mnemonic" in self.nodes[0].listdescriptors(True)['descriptors'][0]
-
-            descriptors = self.nodes[0].listdescriptors(True)['descriptors']
-            assert_equal(descriptors[0]['mnemonic'], descriptors[1]['mnemonic'])
+            for desc in self.nodes[0].listdescriptors()['descriptors']:
+                assert "mnemonic" not in desc
 
             mnemonic_count = 0
-            found_in_encrypted = 0
+            cb_count = 0
+            descriptors = self.nodes[0].listdescriptors(True)['descriptors']
             for desc in descriptors:
                 if 'mnemonic' not in desc:
                     assert not desc['active']
                     # skip imported coinbase private key
+                    cb_count += 1
                     continue
                 assert_equal(len(desc['mnemonic'].split()), 12)
                 mnemonic_count += 1
-                if desc['mnemonic'] == mnemonic_pre:
-                    found_in_encrypted += 1
-                    assert desc['active']
+                assert desc['mnemonic'] == mnemonic_pre
+                assert desc['active']
             # there should 3 descriptors in total
             # one of them is inactive imported private key for coinbase. It has no mnemonic without mnemonic
             # two other should be active and have mnemonic
-            assert_equal(found_in_encrypted, 2)
+            assert_equal(mnemonic_count, 2)
             assert_equal(mnemonic_count, 2)
             assert_equal(len(descriptors), 3)
         else:
@@ -74,8 +93,7 @@ def run_test(self):
         if self.options.descriptors:
             self.nodes[0].createwallet("wallet_256", False, True, "", False, True)  # blank Descriptors
             self.nodes[0].get_wallet_rpc("wallet_256").upgradetohd()
-            # first descriptor is private key with no mnemonic for CbTx (see node.importprivkey), we use number#1 here instead
-            assert_equal(len(self.nodes[0].get_wallet_rpc(self.default_wallet_name).listdescriptors(True)["descriptors"][1]["mnemonic"].split()), 12)  # 12 words by default
+            assert_equal(len(self.get_mnemonic(self.nodes[0].get_wallet_rpc(self.default_wallet_name)).split()), 12)  # 12 words by default
             assert_equal(len(self.nodes[0].get_wallet_rpc("wallet_160").listdescriptors(True)["descriptors"][0]["mnemonic"].split()), 15)              # 15 words
             assert_equal(len(self.nodes[0].get_wallet_rpc("wallet_192").listdescriptors(True)["descriptors"][0]["mnemonic"].split()), 18)              # 18 words
             assert_equal(len(self.nodes[0].get_wallet_rpc("wallet_224").listdescriptors(True)["descriptors"][0]["mnemonic"].split()), 21)              # 21 words