Crash on shutdown with governance tab enabled

[thephez]

Describe the issue

Dash Core crashes on application close in some situations when the Governance tab has been enabled.

Can you reliably reproduce the issue?

Based on info from Discord, several people have done so (I haven't been unable to replicate for some reason). See Discord for more info.

If so, please list the steps to reproduce below:

1. Open v18.0.0.0-rc1, enable Show Governance Tab, close settings dialog, close Dash-Qt -> crash.
2. Open v18.0.0.0-rc1, disable Show Governance Tab, close settings dialog, close Dash-Qt -> no crash.

Expected behaviour

App should not crash

Actual behaviour

App crashes

Screenshots.

N/A

What version of Dash Core are you using?

v18.0.0.0-rc1 although xkcd has reported this on other versions as well.

Machine specs:

Multiple including Linux/Mac/Windows.

Any extra information that might be useful in the debugging process.

A report of recursive_mutex lock failed: Invalid argument in debug.log

Also, this log from xkcd: https://pastebin.com/RW5BvYjs
Excerpt:

2022-04-21T04:17:19Z GUI: updateFonts - widget counts: updated/updatable/total(2/478/798), removed items: mapWidgetDefaultFontSizes/mapFontUpdates(92/7)
2022-04-21T04:17:19Z GUI: requestShutdown : Requesting shutdown
2022-04-21T04:17:19Z Windows Exception: EXCEPTION_ACCESS_VIOLATION
No debug information available for stacktrace. You should add debug information and then run:
dash-qt.exe -printcrashinfo=bvcgc43iinzgc43ijfxgm3ybaafwiyltnawxc5bomv4gklkxnfxgi33xomqek6ddmvyhi2lpny5carkyincvavcjj5hf6qkdincvgu27kzeu6tcbkreu6tqaaa======
2022-04-21T04:17:19Z CConnman::OpenNetworkConnection -- connecting to new peer

[thephez]

This is somehow back in v18 RC3. I have reproduced it when going from governance tab off to on. Others have reported seeing it going the other direction, but I have not seen that one myself.