Corrupted block database on 18.2-RC2 prevents index use

[thephez]

Describe the issue

Dash Core v18.2 RC2 returns the following error in some scenario when certain indexes are enabled.

2022-12-07T16:40:56Z [0%]...[16%]...[25%]...[33%]...[41%]...[50%]...[ProcessBlock] h[795010] numCommitmentsRequired[0] numCommitmentsInNewBlock[0]
2022-12-07T16:40:56Z ERROR: ConnectBlock(DASH): ProcessSpecialTxsInBlock for block 00000086e9bf45802a44258e882865b176d2bcaf425d1c7d9b7acc59b859a5fe failed with bad-cbtx-mnmerkleroot (code 16)
2022-12-07T16:40:56Z ERROR: VerifyDB(): *** found unconnectable block at 795010, hash=00000086e9bf45802a44258e882865b176d2bcaf425d1c7d9b7acc59b859a5fe (bad-cbtx-mnmerkleroot (code 16))
2022-12-07T16:40:56Z : Corrupted block database detected.
Please restart with -reindex or -reindex-chainstate to recover.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

1. Enable txindex=1 and addressindex=1 in dash.conf
2. Run Dash Core v18.2 RC2 on testnet with the -reindex option. I was specifically running dash-qt -conf=<conf file> -reindex.
3. Once reindexing has completed, close Dash Core normally.
4. Reopen Dash Core (without the -reindex parameter)
5. Observe the error reported above

Expected behaviour

Core should run successfully after the reindex

Actual behaviour

Core reports a corrupted block database and shuts down

What version of Dash Core are you using?

Dash Core version v18.2.0-rc.2. Published GitHub binary and self-compiled.

[SomethingUseful]

maybe related. i cant get past block 795015. same version v18.2.0-rc.2.

2022-12-08T10:03:19Z CMasternodePayments::IsTransactionValid -- ERROR failed to find expected payee yac7gAK3cKuDnYD4RmGaJiMnCssgu7Q7A5 in block at height 795016 2022-12-08T10:03:19Z IsBlockPayeeValid -- ERROR: Invalid masternode payment detected at height 795016: CTransaction(hash=0dfad0e56c, ver=3, type=5, vin.size=1, vout.size=2, nLockTime=0, vExtraPayload.size=70) CTxIn(COutPoint(0000000000000000000000000000000000000000000000000000000000000000, 4294967295), coinbase 0388210c0101) CTxOut(nValue=7.20591912, scriptPubKey=76a9141ec5c66e9789c655ae068d35) CTxOut(nValue=10.80887867, scriptPubKey=76a9141ec5c66e9789c655ae068d35) 2022-12-08T10:03:19Z ERROR: ConnectBlock(DASH): couldn't find masternode or superblock payments 2022-12-08T10:03:19Z InvalidChainFound: invalid block=000000245a53c4f9467bd158c55b6dde88fd64147d5749e196bd2e29b7bc7190 height=795016 log2_work=57.50491138 date=2022-09-06T13:29:25Z

[thephez]

@SomethingUseful For testnet a fork is expect at that block. The reason there are no blocks on top of that is being actively investigated.

[thephez]

Note: reindexing using v18.2 RC1 with the same dash.conf does not result in seeing the issue.

[SomethingUseful]

Note: reindexing using v18.2 RC1 with the same dash.conf does not result in seeing the issue.

ive reindexed about 6 times. deleted all block/chain data as well first and still can not get this thing to fully sync.

[qwizzie]

Has this actually been resolved in later v18.2 release candidates ? Since v18.2 will be integrated into v19 due to the required hard fork, perhaps its wise to test for this bug on v18.2.2 / v19 as well.