chore: review unique_identifiers implementations across all state transitions #3187
Description
Summary
The unique_identifiers() method on StateTransitionLike is used for mempool deduplication and error reporting. Each state transition type provides its own implementation.
As we've added new state transition types (address-based, shielded), we should do a review pass to ensure all implementations are consistent and use the most appropriate identifiers for their transition type.
What to review
- Verify each transition uses the correct deduplication key for its semantics
- Check consistency of identifier formats across similar transition types
- Ensure no transition is missing identifiers that should be present
- Review edge cases (e.g., transitions based on asset lock proofs vs address nonces vs nullifiers)
Context
This came up while working on shielded state transitions. Worth a holistic review to make sure everything is aligned.