Skip to content

Commit 206504c

Browse files
authored
Lift pandas pinning (#67)
1 parent 3ae24f7 commit 206504c

File tree

8 files changed

+17
-34
lines changed

8 files changed

+17
-34
lines changed

.github/workflows/pre-commit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ jobs:
99
steps:
1010
- uses: actions/checkout@v2
1111
- uses: actions/setup-python@v2
12-
- uses: pre-commit/action@v2.0.0
12+
- uses: pre-commit/action@v3.0.1

.github/workflows/tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
- name: Setup Conda Environment
2727
uses: conda-incubator/setup-miniconda@v3
2828
with:
29-
miniforge-variant: Mambaforge
3029
miniforge-version: latest
3130
use-mamba: true
3231
channel-priority: strict

.github/workflows/wheels.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ jobs:
2323
fetch-depth: 0
2424
- uses: actions/setup-python@v4
2525
with:
26-
python-version: '3.10'
26+
python-version: '3.10'
2727
- name: Build wheels
2828
run: pip wheel . -w dist
2929
- name: Build Source Dist
3030
run: python setup.py sdist
31-
- uses: actions/upload-artifact@v3
31+
- uses: actions/upload-artifact@v4
3232
with:
3333
name: wheel
3434
path: ./dist/dask_snowflake*
35-
- uses: actions/upload-artifact@v3
35+
- uses: actions/upload-artifact@v4
3636
with:
3737
name: sdist
3838
path: ./dist/dask-snowflake*
@@ -42,11 +42,11 @@ jobs:
4242
needs: [artifacts]
4343
runs-on: ubuntu-latest
4444
steps:
45-
- uses: actions/download-artifact@v3
45+
- uses: actions/download-artifact@v4
4646
with:
4747
name: sdist
4848
path: dist
49-
- uses: actions/download-artifact@v3
49+
- uses: actions/download-artifact@v4
5050
with:
5151
name: wheel
5252
path: dist
@@ -65,11 +65,11 @@ jobs:
6565
permissions:
6666
id-token: write
6767
steps:
68-
- uses: actions/download-artifact@v3
68+
- uses: actions/download-artifact@v4
6969
with:
7070
name: sdist
7171
path: dist
72-
- uses: actions/download-artifact@v3
72+
- uses: actions/download-artifact@v4
7373
with:
7474
name: wheel
7575
path: dist

ci/environment-3.10.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@ dependencies:
66
- python=3.10
77
- dask
88
- distributed
9-
# `pandas=2.2` dropped support for `sqlalchemy<2`, but `snowflake-sqlalchemy`
10-
# doesn't support `sqlalchemy>=2` yet. Temporarily pinning `pandas<2.2` for now.
11-
# xref https://github.com/pandas-dev/pandas/issues/57049
12-
# xref https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380
13-
- pandas<2.2
9+
- pandas
1410
- pyarrow
1511
- snowflake-connector-python >=2.6.0
1612
- snowflake-sqlalchemy
1713
# Testing
18-
- pytest
14+
- pytest

ci/environment-3.11.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@ dependencies:
66
- python=3.11
77
- dask
88
- distributed
9-
# `pandas=2.2` dropped support for `sqlalchemy<2`, but `snowflake-sqlalchemy`
10-
# doesn't support `sqlalchemy>=2` yet. Temporarily pinning `pandas<2.2` for now.
11-
# xref https://github.com/pandas-dev/pandas/issues/57049
12-
# xref https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380
13-
- pandas<2.2
9+
- pandas
1410
- pyarrow
1511
- snowflake-connector-python >=2.6.0
1612
- snowflake-sqlalchemy
1713
# Testing
18-
- pytest
14+
- pytest

ci/environment-3.12.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@ dependencies:
66
- python=3.12
77
- dask
88
- distributed
9-
# `pandas=2.2` dropped support for `sqlalchemy<2`, but `snowflake-sqlalchemy`
10-
# doesn't support `sqlalchemy>=2` yet. Temporarily pinning `pandas<2.2` for now.
11-
# xref https://github.com/pandas-dev/pandas/issues/57049
12-
# xref https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380
13-
- pandas<2.2
9+
- pandas
1410
- pyarrow
1511
- snowflake-connector-python >=2.6.0
1612
- snowflake-sqlalchemy
1713
# Testing
18-
- pytest
14+
- pytest

ci/environment-3.9.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@ dependencies:
66
- python=3.9
77
- dask
88
- distributed
9-
# `pandas=2.2` dropped support for `sqlalchemy<2`, but `snowflake-sqlalchemy`
10-
# doesn't support `sqlalchemy>=2` yet. Temporarily pinning `pandas<2.2` for now.
11-
# xref https://github.com/pandas-dev/pandas/issues/57049
12-
# xref https://github.com/snowflakedb/snowflake-sqlalchemy/issues/380
13-
- pandas<2.2
9+
- pandas
1410
- pyarrow
1511
- snowflake-connector-python >=2.6.0
1612
- snowflake-sqlalchemy
1713
# Testing
18-
- pytest
14+
- pytest

dask_snowflake/tests/test_core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def test_read_empty_result(table, connection_kwargs, client):
7171

7272
result = read_snowflake(
7373
f"SELECT * FROM {table} where A > %(target)s",
74-
execute_params={"target": df.A.max()},
74+
execute_params={"target": df.A.max().item()},
7575
connection_kwargs=connection_kwargs,
7676
npartitions=2,
7777
)

0 commit comments

Comments
 (0)