Skip to content

Commit ecab98e

Browse files
committed
Default config values for ngpus, scheduler_ngpus and worker_ngpus are now converted to integers before being checked to be greater than the value of zero. Beforehand, these values were assumed to be integers, causing a type error for all instantiations of GCPCluster, creating a breaking change
1 parent 4f8682b commit ecab98e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

dask_cloudprovider/gcp/instances.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -662,17 +662,18 @@ def __init__(
662662
self.scheduler_machine_type = machine_type
663663
self.worker_machine_type = machine_type
664664

665-
self.ngpus = ngpus or self.config.get("ngpus")
665+
ngpus_value = ngpus or self.config.get("ngpus")
666+
self.ngpus = int(ngpus_value) if ngpus_value else None
666667
if not self.ngpus:
667668
self.scheduler_ngpus = (
668669
scheduler_ngpus
669670
if scheduler_ngpus is not None
670-
else self.config.get("scheduler_ngpus", 0)
671+
else int(self.config.get("scheduler_ngpus") or 0)
671672
)
672673
self.worker_ngpus = (
673674
worker_ngpus
674675
if worker_ngpus is not None
675-
else self.config.get("worker_ngpus", 0)
676+
else int(self.config.get("worker_ngpus") or 0)
676677
)
677678
else:
678679
if scheduler_ngpus is not None or worker_ngpus is not None:

0 commit comments

Comments
 (0)