Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize task name definitions #363

Open
jkanche opened this issue Jul 12, 2022 · 2 comments
Open

Parameterize task name definitions #363

jkanche opened this issue Jul 12, 2022 · 2 comments
Labels
bug Something isn't working provider/aws/ecs Cluster provider for AWS ECS

Comments

@jkanche
Copy link

jkanche commented Jul 12, 2022

on https://github.com/dask/dask-cloudprovider/blob/main/dask_cloudprovider/aws/ecs.py#L1264 the name of the worker task definition is hardcoded to dask-worker. This creates conflicts when I want to run multiple Fargate clusters, each with their own images and dependencies.
@jacobtomlinson jacobtomlinson added bug Something isn't working provider/aws/ecs Cluster provider for AWS ECS labels Jul 13, 2022
@jacobtomlinson
Copy link
Member

jacobtomlinson commented Jul 13, 2022 •
edited
Loading

Thanks for raising this. Perhaps we should do two things here:

  • Make the task definition name configurable
  • Make the default task definition name a random UUID

Do you have any interest in contributing a fix for this?

@jkanche
Copy link
Author

jkanche commented Jul 14, 2022 •
edited
Loading

@jacobtomlinson happy to help; working on this PR: #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working provider/aws/ecs Cluster provider for AWS ECS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkanche @jacobtomlinson