Skip to content

Commit 2d19d1c

Browse files
authored
Remove protocol="ucx" support in favor of distributed-ucxx (#9105)
* Remove UCX comm and tests * Raise deprecation exception * Improve warning/error message
1 parent 0f0adef commit 2d19d1c

File tree

9 files changed

+34
-1305
lines changed

9 files changed

+34
-1305
lines changed

distributed/comm/__init__.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,14 @@ def _register_transports():
2323
backends["tls"] = tcp.TLSBackend()
2424

2525
try:
26-
from distributed.comm import ucx
26+
# If `distributed-ucxx` is installed, it takes over the protocol="ucx" support
27+
import distributed_ucxx
2728
except ImportError:
28-
pass
29+
try:
30+
# Else protocol="ucx" will raise a deprecation warning and exception
31+
from distributed.comm import ucx
32+
except ImportError:
33+
pass
2934

3035

3136
_register_transports()

distributed/comm/tests/test_comms.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -570,16 +570,6 @@ async def client_communicate(key, delay=0):
570570
listener.stop()
571571

572572

573-
@pytest.mark.gpu
574-
@gen_test()
575-
async def test_ucx_client_server(ucx_loop):
576-
pytest.importorskip("distributed.comm.ucx")
577-
ucp = pytest.importorskip("ucp")
578-
579-
addr = ucp.get_address()
580-
await check_client_server("ucx://" + addr)
581-
582-
583573
def tcp_eq(expected_host, expected_port=None):
584574
def checker(loc):
585575
host, port = parse_host_port(loc)
@@ -1395,7 +1385,6 @@ async def test_do_not_share_buffers(tcp, list_cls):
13951385
See Also
13961386
--------
13971387
test_share_buffer_with_header
1398-
test_ucx.py::test_do_not_share_buffers
13991388
"""
14001389
np = pytest.importorskip("numpy")
14011390

0 commit comments

Comments
 (0)